mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jojy Varghese" <j...@mesosphere.io>
Subject Re: Review Request 37426: MESOS-3251 : Fixing "host" field of request header.
Date Mon, 17 Aug 2015 21:56:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37426/
-----------------------------------------------------------

(Updated Aug. 17, 2015, 9:56 p.m.)


Review request for mesos, Anand Mazumdar and Timothy Chen.


Changes
-------

Added checks for standard ports.


Bugs: MESOS-3251
    https://issues.apache.org/jira/browse/MESOS-3251


Repository: mesos


Description
-------

Currently libprocess http API sets the "Host" header field from the peer socket
address (IP:port). The problem is that socket address might not be right HTTP
server and might be just a proxy.
  Changed the logic to look for http server URL's domain first to populate the
"Host" field.


Diffs (updated)
-----

  3rdparty/libprocess/src/http.cpp 660950fc9b66e8bca24d0888dda1f20b44d8ff49 

Diff: https://reviews.apache.org/r/37426/diff/


Testing
-------

make check.


Thanks,

Jojy Varghese


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message