mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marco Massenzio" <ma...@mesosphere.io>
Subject Re: Review Request 33339: Add a Java example framework to test persistent volumes.
Date Fri, 14 Aug 2015 22:30:31 GMT


> On Aug. 14, 2015, 10:28 p.m., Marco Massenzio wrote:
> >

[mmm turns out that it matters WHICH boxes you put your general comments in :) - copied here,
as they make sense *before* the nitpicking that follows]

Again, sorry it's taken so long to get round to doing this review and soooo many thanks for
doing this!

I've only got halfway through, I'll try my best to do more in the next few days, less craziness
(here's to hoping, anyway!)

I notice the one file runs for >1,000 lines - the Resource class is probably worth having
in its own .java file, and probably Flags too - maybe you can refactor further other parts
too.

In general, I like Java class files to only rarely exceed the 300-400 lines - bigger than
that, it usually signals design choices that are sub-optimal in separating concerns.

As I mentioned, it's great that you're doing this: as someone who wants to learn more about
persistence framework, I'm looking forward to having this committed and being able to also
hack around with it :)

Maybe, we may also get a blog entry out of it, as we expose persistent volumes to a wider
public and show folks how to use them in a Java framework.


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33339/#review95473
-----------------------------------------------------------


On June 21, 2015, 9:57 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33339/
> -----------------------------------------------------------
> 
> (Updated June 21, 2015, 9:57 a.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, and Marco Massenzio.
> 
> 
> Bugs: MESOS-2610
>     https://issues.apache.org/jira/browse/MESOS-2610
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add a Java example framework to test persistent volumes.
> 
> 
> Diffs
> -----
> 
>   configure.ac 563e9c529444b3e980db6d04173f0d016a737c74 
>   src/Makefile.am e7de0f3d1a5efeaef47d5074defe3b40db94f573 
>   src/examples/java/TestPersistentVolumeFramework.java PRE-CREATION 
>   src/examples/java/test-persistent-volume-framework.in PRE-CREATION 
>   src/tests/examples_tests.cpp 2ff6e7a449cc5037f9a3c8d6938855c35e389cca 
>   src/tests/java_persistent_volume_framework_test.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33339/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message