mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joerg Schad" <jo...@mesosphere.io>
Subject Re: Review Request 36847: Added HTTP Delete Method.
Date Thu, 13 Aug 2015 16:17:53 GMT


> On Aug. 6, 2015, 9:56 a.m., Alexander Rojas wrote:
> > 3rdparty/libprocess/include/process/http.hpp, line 754
> > <https://reviews.apache.org/r/36847/diff/7/?file=1028524#file1028524line754>
> >
> >     I'm rather late to the party, but AFAIK Mesos appreciates consistency over doing
some things right and some wrong.
> >     
> >     The Mesos way would be to add the method in a consistent way and then do a sweep
change for all the other http calls.
> >     
> >     That being said, the way I have seen other http libraries getting around the
keyword issue is by using an underscore at some point.
> 
> Marco Massenzio wrote:
>     To paraphrase a well-known maxim... I'd rather be sometimes right, than consistently
wrong :)
>     (and, as per my usual, adding here my favorite [demotivator](http://despair.com/collections/demotivators/products/consistency)
:D
>     
>     More seriously, good point about underscore, the problem here is that wherever you
put it, you end up violating a style rule and/or doing something ugly - a real conumdrum!
> 
> Bernd Mathiske wrote:
>     There is NO consistent way to add the method and it MUST be added. Therefore I prefer
a way that is, halas, inconsistent, but at least not wrong when regarded in isolation in any
additional ways. Then, as an additional issue/patch we may/should choose to bring the other
calls into line. (An underscore does not achieve any of these objectives.)
> 
> Bernd Mathiske wrote:
>     All that said, I propose that we choose this name for the method: requestDelete.
Reasons:
>     - Avoids keyword problem.
>     - Is short enough to be applied to all other HTTP requests: requestGet, requestAuth,
etc.; clarifies what these do.
>     - Reads as a verb.
>     - Avoids "send" as part of the name, which is kinda wrong, since we do more than
just sending. We also wait for the response via a future.
> 
> Marco Massenzio wrote:
>     +1

I added MESOS-3256 to track the renaming effort.


- Joerg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36847/#review94388
-----------------------------------------------------------


On Aug. 4, 2015, 10:57 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36847/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2015, 10:57 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
> 
> 
> Bugs: MESOS-3152
>     https://issues.apache.org/jira/browse/MESOS-3152
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp b8d930058aa3ae9d21ae0f7b420d49f2448f84b1

>   3rdparty/libprocess/src/http.cpp 4dcbd74b894b483c4d166c23fac55ac8dba75166 
>   3rdparty/libprocess/src/tests/http_tests.cpp ecbcbd552ac834659860627c82628ed38e6139b3

> 
> Diff: https://reviews.apache.org/r/36847/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message