mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jiang Yan Xu" <...@jxu.me>
Subject Re: Review Request 37236: Added the linux filesystem isolator.
Date Thu, 13 Aug 2015 00:01:51 GMT


> On Aug. 12, 2015, 3:59 p.m., Jiang Yan Xu wrote:
> > include/mesos/mesos.proto, line 1255
> > <https://reviews.apache.org/r/37236/diff/3/?file=1038690#file1038690line1255>
> >
> >     There is another reference to "Absoluate path" here which should be updated.
> 
> Jie Yu wrote:
>     It says "... or a path relative to the container work directory"

My bad.


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37236/#review95195
-----------------------------------------------------------


On Aug. 12, 2015, 11:54 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37236/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2015, 11:54 a.m.)
> 
> 
> Review request for mesos, Lily Chen, Ian Downes, Jojy Varghese, Timothy Chen, Vinod Kone,
and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-2794
>     https://issues.apache.org/jira/browse/MESOS-2794
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the linux filesystem isolator.
> 
> Note that the persistent volume part (i.e., update) hasn't been implemented yet.
> 
> This review is derived from https://reviews.apache.org/r/36429/
> 
> Tests are in the subsequent review.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 8a423a56a341e380434e7df91868f1813024840c 
>   src/Makefile.am 07502f0f5523b972888ceab9cf3af309c8441d7f 
>   src/slave/containerizer/isolators/filesystem/linux.hpp PRE-CREATION 
>   src/slave/containerizer/isolators/filesystem/linux.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/containerizer.cpp 2cbb879888baf6aff76fbd7c1e19027300fb86e3

> 
> Diff: https://reviews.apache.org/r/37236/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message