mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jiang Yan Xu" <...@jxu.me>
Subject Re: Review Request 37330: Added persistent volume support for linux filesystem isolator.
Date Wed, 12 Aug 2015 22:47:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37330/#review95154
-----------------------------------------------------------


This thing is rather complex and it deals with Mesos managed persisetent volumes and other
system volumes in different but related ways; rootfs may or may not be used; and we'll provision
image volumes later. I hope we iterate on this later and look for ways (more documentation,
refactorings) to simplify and clarify the code.


src/slave/containerizer/isolators/filesystem/linux.hpp (line 105)
<https://reviews.apache.org/r/37330/#comment149999>

    Mention it's an absoluate path and always under the rootfs?



src/slave/containerizer/isolators/filesystem/linux.cpp (lines 292 - 294)
<https://reviews.apache.org/r/37330/#comment150043>

    Add a TODO here to change this after we start to provsision images in volumes?



src/slave/containerizer/isolators/filesystem/linux.cpp (line 485)
<https://reviews.apache.org/r/37330/#comment149989>

    s/other/another/



src/slave/containerizer/isolators/filesystem/linux.cpp (line 526)
<https://reviews.apache.org/r/37330/#comment150038>

    ```
    Check that the source of the mount matches the entry with the same target in the mount
table if one can be found.
    ```



src/slave/containerizer/isolators/filesystem/linux.cpp (line 553)
<https://reviews.apache.org/r/37330/#comment149990>

    Aha, OK I see that the assignment happens here.



src/slave/containerizer/isolators/filesystem/linux.cpp (line 579)
<https://reviews.apache.org/r/37330/#comment150042>

    What happens when persistent volumes are used without a new rootfs?



src/slave/containerizer/isolators/filesystem/linux.cpp (line 589)
<https://reviews.apache.org/r/37330/#comment150016>

    s/all/All/


- Jiang Yan Xu


On Aug. 10, 2015, 6:57 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37330/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2015, 6:57 p.m.)
> 
> 
> Review request for mesos, Lily Chen, Ian Downes, Jojy Varghese, Timothy Chen, Vinod Kone,
and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-2794
>     https://issues.apache.org/jira/browse/MESOS-2794
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added persistent volume support for linux filesystem isolator.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/isolators/filesystem/linux.hpp PRE-CREATION 
>   src/slave/containerizer/isolators/filesystem/linux.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37330/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> Will follow up with more tests specificially for persistent volumes.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message