mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 37284: Maintenance Primitives: Added support for Accept / Decline of InverseOffers in master.
Date Wed, 12 Aug 2015 21:43:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37284/#review95182
-----------------------------------------------------------



src/master/master.cpp (line 2716)
<https://reviews.apache.org/r/37284/#comment150020>

    This `continue` seems extraneous.



src/master/master.cpp (line 3162)
<https://reviews.apache.org/r/37284/#comment150019>

    Is this `continue` necessary?
    
    (Same question for the other instances below.)


- Joseph Wu


On Aug. 10, 2015, 12:06 a.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37284/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2015, 12:06 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
>     https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 08dd34d9d18f547c6e8d04caf9e39a2b3ffc5f63 
> 
> Diff: https://reviews.apache.org/r/37284/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message