mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 37330: Added persistent volume support for linux filesystem isolator.
Date Wed, 12 Aug 2015 19:22:20 GMT


> On Aug. 12, 2015, 1:43 a.m., Timothy Chen wrote:
> > src/slave/containerizer/isolators/filesystem/linux.cpp, line 399
> > <https://reviews.apache.org/r/37330/diff/2/?file=1037046#file1037046line399>
> >
> >     Can we also log the container id and it's the linux filesystem isolator? It's
much easier to debug instead of just seeing a message says "Unknown container".

The caller will print the container id in the error message.


> On Aug. 12, 2015, 1:43 a.m., Timothy Chen wrote:
> > src/slave/containerizer/isolators/filesystem/linux.cpp, line 412
> > <https://reviews.apache.org/r/37330/diff/2/?file=1037046#file1037046line412>
> >
> >     I don't think we hold reference to tempoaries?

It returns a reference (not a temporary).


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37330/#review95046
-----------------------------------------------------------


On Aug. 11, 2015, 1:57 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37330/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2015, 1:57 a.m.)
> 
> 
> Review request for mesos, Lily Chen, Ian Downes, Jojy Varghese, Timothy Chen, Vinod Kone,
and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-2794
>     https://issues.apache.org/jira/browse/MESOS-2794
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added persistent volume support for linux filesystem isolator.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/isolators/filesystem/linux.hpp PRE-CREATION 
>   src/slave/containerizer/isolators/filesystem/linux.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37330/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> Will follow up with more tests specificially for persistent volumes.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message