mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Isabel Jimenez" <cont...@isabeljimenez.com>
Subject Re: Review Request 37403: Using AcceptMediaType Request method to validate Accept header
Date Wed, 12 Aug 2015 19:19:00 GMT


> On Aug. 12, 2015, 6:31 p.m., Anand Mazumdar wrote:
> > src/master/http.cpp, line 395
> > <https://reviews.apache.org/r/37403/diff/1/?file=1038481#file1038481line395>
> >
> >     This would crash if there was no accept header specified ?

No this can only enter the if with an accept header


- Isabel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37403/#review95135
-----------------------------------------------------------


On Aug. 12, 2015, 5:50 p.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37403/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2015, 5:50 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-2497
>     https://issues.apache.org/jira/browse/MESOS-2497
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Using AcceptMediaType Request method to validate request 'Accept' HTTP header in Scheduler
HTTP API
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 579c009 
>   src/tests/http_api_tests.cpp aef3c4b 
> 
> Diff: https://reviews.apache.org/r/37403/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message