mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jiang Yan Xu" <...@jxu.me>
Subject Re: Review Request 37237: Added a few MesosContainerizer filesystem tests to test the linux filesystem isolator.
Date Wed, 12 Aug 2015 18:16:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37237/#review95025
-----------------------------------------------------------

Ship it!



src/tests/containerizer/filesystem_isolator_tests.cpp (line 157)
<https://reviews.apache.org/r/37237/#comment149961>

    So this relies on the launch not failing to indicate it has successfully pivoted?
    
    Ideally there is something to prove it's indeed in the new rootfs.



src/tests/containerizer/provisioner.hpp (line 34)
<https://reviews.apache.org/r/37237/#comment149796>

    Should this be called MockProvisioner? I think we use TestXYZ to 'XYZ that faciliates
tests' and MockXYZ for 'Fake XYZ implemented by GMock'. e.g., MockSlave.



src/tests/containerizer/provisioner.hpp (lines 46 - 47)
<https://reviews.apache.org/r/37237/#comment149956>

    Does this not cause the issue mpark [mentioned](http://mail-archives.apache.org/mod_mbox/mesos-dev/201507.mbox/%3CCAL3vCQqrCwbbLf3u2fdHu1MyOHqgqJUB9UL3zJN+OQXx0ONrqA@mail.gmail.com%3E)?
    
    May have to put them in tests themselves.


- Jiang Yan Xu


On Aug. 7, 2015, 5:32 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37237/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2015, 5:32 p.m.)
> 
> 
> Review request for mesos, Lily Chen, Ian Downes, Jojy Varghese, Timothy Chen, Vinod Kone,
and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-2794
>     https://issues.apache.org/jira/browse/MESOS-2794
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a few MesosContainerizer filesystem tests to test the linux filesystem isolator.
> 
> This adds the tests for https://reviews.apache.org/r/37236/
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am c213ac779e7acc3235312ca9524b3959417b8c33 
>   src/tests/containerizer/filesystem_isolator_tests.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37237/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message