mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rojas" <alexan...@mesosphere.io>
Subject Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
Date Wed, 12 Aug 2015 14:56:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36048/
-----------------------------------------------------------

(Updated Aug. 12, 2015, 4:56 p.m.)


Review request for mesos, Adam B, Alexander Rukletsov, Bernd Mathiske, Kapil Arya, Jan Schlicht,
and Till Toenshoff.


Bugs: MESOS-2946
    https://issues.apache.org/jira/browse/MESOS-2946


Repository: mesos


Description
-------

Splits and updates the original declaration of the `Authorizer` into its interface and a default
implementation, the `LocalAuthorizer`.

Following the pattern of the modularized `Authenticator`, it generates a default constructor
which is required when writing a `TYPED_TEST` in
a follow up patch. Additionally, an initialize method has been added, needed for passing in
the current ACL definitions as provided via
flags.

Other changes are just updates to allow for compilation.


Diffs (updated)
-----

  include/mesos/authorizer/authorizer.hpp PRE-CREATION 
  include/mesos/authorizer/authorizer.proto PRE-CREATION 
  include/mesos/mesos.proto 8a423a56a341e380434e7df91868f1813024840c 
  include/mesos/type_utils.hpp 6ff061c94e9d3dbb55bd047840b2012d11e3a0f2 
  src/Makefile.am 07502f0f5523b972888ceab9cf3af309c8441d7f 
  src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f 
  src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc 
  src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 
  src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 
  src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff 
  src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f 
  src/master/http.cpp 579c009a1b43bc25c294366de29a56dacc734791 
  src/master/main.cpp e05a472b86170eb26df26aaa4b65437fcdd413ce 
  src/master/master.hpp 4e2947003247c3d7bf407d6d709faf2e878418f3 
  src/master/master.cpp 398203d9367f85340166e66ecc34b9a33dd81048 
  src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 
  src/tests/cluster.hpp 422ebd17da045002294e67027e9ebe1377bc53cd 
  src/tests/mesos.hpp 8b486145dfd2a554689f6e84d76b50508979fea2 
  src/tests/mesos.cpp a2a469e2a581dc6c566dafd4acd2a95c0238399f 

Diff: https://reviews.apache.org/r/36048/diff/


Testing
-------

make check


Thanks,

Alexander Rojas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message