mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 37330: Added persistent volume support for linux filesystem isolator.
Date Wed, 12 Aug 2015 01:43:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37330/#review95046
-----------------------------------------------------------



src/slave/containerizer/isolators/filesystem/linux.cpp (line 399)
<https://reviews.apache.org/r/37330/#comment149834>

    Can we also log the container id and it's the linux filesystem isolator? It's much easier
to debug instead of just seeing a message says "Unknown container".



src/slave/containerizer/isolators/filesystem/linux.cpp (line 412)
<https://reviews.apache.org/r/37330/#comment149835>

    I don't think we hold reference to tempoaries?


- Timothy Chen


On Aug. 11, 2015, 1:57 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37330/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2015, 1:57 a.m.)
> 
> 
> Review request for mesos, Lily Chen, Ian Downes, Jojy Varghese, Timothy Chen, Vinod Kone,
and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-2794
>     https://issues.apache.org/jira/browse/MESOS-2794
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added persistent volume support for linux filesystem isolator.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/isolators/filesystem/linux.hpp PRE-CREATION 
>   src/slave/containerizer/isolators/filesystem/linux.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37330/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> Will follow up with more tests specificially for persistent volumes.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message