mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marco Massenzio" <ma...@mesosphere.io>
Subject Re: Review Request 37126: Added authorization for dynamic reservation master endpoints.
Date Wed, 12 Aug 2015 00:19:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37126/#review95021
-----------------------------------------------------------



src/master/http.cpp (line 593)
<https://reviews.apache.org/r/37126/#comment149784>

    feel free to make fun of my ignorance... but why not a "real" lambda function here?
    (and below too)



src/tests/reservation_endpoints_tests.cpp (line 980)
<https://reviews.apache.org/r/37126/#comment149788>

    nit: s/set-up/setup



src/tests/reservation_endpoints_tests.cpp (line 1026)
<https://reviews.apache.org/r/37126/#comment149791>

    nit: I believe we prefer the use of `using` for std::string?
    (I'm sure there's already one about 1,000 lines above here...)


- Marco Massenzio


On Aug. 5, 2015, 10:46 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37126/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2015, 10:46 a.m.)
> 
> 
> Review request for mesos, Adam B and Jie Yu.
> 
> 
> Bugs: MESOS-3062
>     https://issues.apache.org/jira/browse/MESOS-3062
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 76e70801925041f08bc94f0ca18c86f1a573b2b3 
>   src/master/master.hpp e44174976aa64176916827bec4c911333c9a91db 
>   src/tests/reservation_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37126/diff/
> 
> 
> Testing
> -------
> 
> Added tests to `src/tests/reservation_endpoints_tests.cpp` + `make check`.
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message