mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jiang Yan Xu" <...@jxu.me>
Subject Re: Review Request 37311: Implemented a 'read-only' Appc image store.
Date Mon, 10 Aug 2015 22:51:21 GMT


> On Aug. 10, 2015, 3:20 p.m., Timothy Chen wrote:
> > src/tests/containerizer/appc_provisioner_tests.cpp, line 119
> > <https://reviews.apache.org/r/37311/diff/2/?file=1036569#file1036569line119>
> >
> >     Btw looking at this and the read-only store, is there documentation around how
users can potentially use this like a user guide?

User guide for the image store/provisioner or just the read-only store? I don't think a 'read-only'
store is going to be useful as a released feature (even though we have concerns for fetching
into the store here right now). The 'put' feature will be added before a release.


> On Aug. 10, 2015, 3:20 p.m., Timothy Chen wrote:
> > src/slave/containerizer/provisioners/appc/store.cpp, line 63
> > <https://reviews.apache.org/r/37311/diff/2/?file=1036566#file1036566line63>
> >
> >     This is a unordered list of layers for this image then? Who is keeping the order
of the dependencies?

No, this is purely a way of organizing images in the store: images of the same name are put
under the same key: because we know the name is always going to be specified. This way is
the image match process during provisioning can work on a shorter list narrowed down from
all images currently in the store.

The order of the dependencies are kept track of in the AppcImageManifest, when provisioned
by the backend dependencies are applied according to the order specified there.


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37311/#review94814
-----------------------------------------------------------


On Aug. 10, 2015, 12:19 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37311/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2015, 12:19 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-3194
>     https://issues.apache.org/jira/browse/MESOS-3194
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented a 'read-only' Appc image store.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 942003149b071a322933e2c085d9122903f69713 
>   src/slave/containerizer/provisioners/appc/store.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/appc/store.cpp PRE-CREATION 
>   src/slave/flags.hpp 881d494c06fea5c382d27b357d65c1baf201ae46 
>   src/slave/flags.cpp 82b6cf47af26f0533ff603a67240777e9a9b986e 
>   src/tests/containerizer/appc_provisioner_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37311/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message