mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <mazumdar.an...@gmail.com>
Subject Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks
Date Mon, 10 Aug 2015 19:20:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36720/
-----------------------------------------------------------

(Updated Aug. 10, 2015, 7:20 p.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
-------

Re-opened to remove stale depedency.


Bugs: MESOS-2294
    https://issues.apache.org/jira/browse/MESOS-2294


Repository: mesos


Description
-------

Split review out of r36318. This change adds the functionality of making a http call for subscribe
and the master responding with a subscribed event on the persistent stream.

Also added functionality for framework failover equivalent of re-register. It should now be
possible to merge the subscribed(...) introduced in this review and the re-factor that happened
in MESOS-3182.

- Made a new function for exited()/failoverFramework for http frameworks that invoke into
the common continuation function for pid/http frameworks thereafter.
- The re-register functionality equivalent goes in _subscribe(...)


Diffs
-----

  src/master/http.cpp 76e70801925041f08bc94f0ca18c86f1a573b2b3 
  src/master/master.hpp 53420ca7d503296fbe11b1ea0795afe2ebf86255 
  src/master/master.cpp d699e4bc3cf734a516a6baf329919e04744b5702 

Diff: https://reviews.apache.org/r/36720/diff/


Testing
-------

make check + adding tests in a different patch.


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message