mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marco Massenzio" <ma...@mesosphere.io>
Subject Re: Review Request 36431: Show stdout/stderr when using mesos-execute.
Date Sat, 08 Aug 2015 08:35:17 GMT


> On Aug. 6, 2015, 11:43 p.m., Marco Massenzio wrote:
> > Before we go too far down this path, can you please see https://reviews.apache.org/r/36424/
and see whether it does what you are trying to achieve here?
> > (maybe not, I'm not familiar at all with `cli` - just asking)
> 
> haosdent huang wrote:
>     Hi, @marco .Thank you for your remind. I take a look of [r36424](https://reviews.apache.org/r/36424/)
. This review is to execute command in local and get its stdout/stderr, right? If so, it is
different with my patch. My patch is try to get stdout/stderr of task from slave. It fetch
stdout/stderr from slave, maybe in remote machine.

Got it.
Sounds good.

Will do a review when I have some time (next week it's going to be tough with 0.24 coming
up) - at a quick glance, it looks like a pretty long method (also, inside a .hpp file? not
sure, I just skimmed it): if you don't want to wait for me, you can start thinking about how
to break it up in smaller, helper methods; remove all the hard-coded "magic numbers" for timeouts
(should be either constants or, even better, user configurable, with sensible defaults); and
minimize the use of `state.json` if you can (or even use the `summary` endpoint) as it's a
"heavy" endpoint and can be heavy on a master with many slaves/frameworks/tasks.


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36431/#review94460
-----------------------------------------------------------


On Aug. 7, 2015, 10:37 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36431/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2015, 10:37 a.m.)
> 
> 
> Review request for mesos, Adam B and Michael Park.
> 
> 
> Bugs: MESOS-1084
>     https://issues.apache.org/jira/browse/MESOS-1084
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Show stdout/stderr when using mesos-execute.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp d070164e080cb74ee15d3184487a121f429a29fc 
> 
> Diff: https://reviews.apache.org/r/36431/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> ![demo](https://issues.apache.org/jira/secure/attachment/12744923/12744923_show_stdout_stderr.gif
"Demo")
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message