mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 37194: Fixed a bug in the MesosContainerizer creation logic.
Date Thu, 06 Aug 2015 20:48:51 GMT


> On Aug. 6, 2015, 8:43 p.m., Timothy Chen wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, line 132
> > <https://reviews.apache.org/r/37194/diff/1/?file=1033640#file1033640line132>
> >
> >     Just a question when looking at this code again, is it possible for a user to
specifiy a empty string in flags.isolation, which overrides the default value and we end up
a bad string with this?

Yeah, it's possible. But we use 'strings::tokenize' below, which will correctly handle this
case.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37194/#review94442
-----------------------------------------------------------


On Aug. 6, 2015, 6:19 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37194/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2015, 6:19 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed a bug in the MesosContainerizer creation logic. I did a few small style fixes and
added a few more comments in the patch as well.
> 
> The bug is that currently we only put filesystem isolator to the front if it's coming
from modules.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp 6d07ff151770bac4eeeb7cd8c9d03f54f2e78ec1

> 
> Diff: https://reviews.apache.org/r/37194/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message