mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework
Date Thu, 06 Aug 2015 17:10:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37082/#review94422
-----------------------------------------------------------


Patch looks great!

Reviews applied: [37080, 36720, 37082]

All tests passed.

- Mesos ReviewBot


On Aug. 6, 2015, 4:26 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37082/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2015, 4:26 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This implements the tests for http framework subscribe/failover/upgrade from a pid based
framework. The test are parameterized on content type and hence test both json/protobuf responses.
> 
> 
> Diffs
> -----
> 
>   src/tests/http_api_tests.cpp 586d11288828fe9997e54f5dbd7d28c200e973f5 
> 
> Diff: https://reviews.apache.org/r/37082/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message