mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rojas" <alexan...@mesosphere.io>
Subject Re: Review Request 37065: Fixed MemIsolatorTest failure on OSX.
Date Thu, 06 Aug 2015 11:47:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37065/#review94394
-----------------------------------------------------------



src/tests/containerizer/memory_test_helper.cpp (lines 75 - 76)
<https://reviews.apache.org/r/37065/#comment148980>

    Not a big fan of explain how something will be used in the method description. What if
we remove references to `mlockall()` and `mlock()` here. Something a long the lines of:
    
    > This helper allocates memory and locks it to the physical memory so it won't get
swapped by the OS.



src/tests/containerizer/memory_test_helper.cpp (lines 79 - 86)
<https://reviews.apache.org/r/37065/#comment148981>

    After reading the man pages, `mlock()` exists in Linux too and frankly it looks safer
to use than `mlockall()`. 
    
    `mlock()` will only lock the memory passed to the call in the physical memory while `mlockall()`
will lock every new allocation after we made this call (and that includes stack, heap and
code sections) until we make a `munlockall()` call, which we don't.


- Alexander Rojas


On Aug. 6, 2015, 7:54 a.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37065/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2015, 7:54 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Michael Park.
> 
> 
> Bugs: MESOS-3197
>     https://issues.apache.org/jira/browse/MESOS-3197
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/memory_test_helper.cpp 5e40b747f4266e7532baf8fd02ea5db0955124d2

> 
> Diff: https://reviews.apache.org/r/37065/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message