mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joerg Schad" <jo...@mesosphere.io>
Subject Re: Review Request 37075: Protobuf definitions instructing the fetcher cache about checksums and their validation.
Date Thu, 06 Aug 2015 11:22:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37075/#review94391
-----------------------------------------------------------



include/mesos/mesos.proto (line 292)
<https://reviews.apache.org/r/37075/#comment148967>

    It reads somehow weird to start with the behavior if not present before knowing what the
flag is about.... Could you add a short descriptive sentence (as above)...


- Joerg Schad


On Aug. 5, 2015, 11:37 a.m., Bernd Mathiske wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37075/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2015, 11:37 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-3208
>     https://issues.apache.org/jira/browse/MESOS-3208
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Protobuf definitions instructing the fetcher cache about checksums and their validation.
First in a series of patches implementing phase 1 of MESOS-2073 (see comments in the ticket).
There are references to docs in this patch, but updating docs will be in the last patch.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba 
> 
> Diff: https://reviews.apache.org/r/37075/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd Mathiske
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message