mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 37142: Removed the unneeded ExecutorInfo from Container struct in MesosContainerizer.
Date Wed, 05 Aug 2015 23:47:40 GMT


> On Aug. 5, 2015, 11:45 p.m., Timothy Chen wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, line 480
> > <https://reviews.apache.org/r/37142/diff/1/?file=1032862#file1032862line480>
> >
> >     This means we no longer support default container info? I don't see this being
used anywhere else then now?

It's still supported. This is in the recovery path (meaning that the container has already
been launched, and volumes have already been mounted). We still apply the default container
info in the launch path.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37142/#review94328
-----------------------------------------------------------


On Aug. 5, 2015, 9:22 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37142/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2015, 9:22 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed the unneeded ExecutorInfo from Container struct in MesosContainerizer.
> 
> This is no longer needed since we are going to call provisioner->destory(containerId)
for every provisioners. See r37105 for more details.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.hpp 8851d30af56b4f9fb95450ac1f42ab550e3df9ff

>   src/slave/containerizer/mesos/containerizer.cpp 6d07ff151770bac4eeeb7cd8c9d03f54f2e78ec1

> 
> Diff: https://reviews.apache.org/r/37142/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message