mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Review Request 37091: Stopped mutating executor info with default container info.
Date Tue, 04 Aug 2015 19:01:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37091/
-----------------------------------------------------------

Review request for mesos, Ben Mahler, Ian Downes, Timothy Chen, and Vinod Kone.


Bugs: MESOS-2463
    https://issues.apache.org/jira/browse/MESOS-2463


Repository: mesos


Description
-------

Stopped mutating executor info with default container info.

This is a bug which could cause the same issue described in MESOS-2463.

Now, filling the default container info is done by the containerizer. As the TODO suggested,
we probably should checkpoint the filled default container info in case the slave changes
the flags.


Diffs
-----

  src/slave/containerizer/mesos/containerizer.cpp 6d07ff151770bac4eeeb7cd8c9d03f54f2e78ec1

  src/slave/slave.cpp 6b21db973dc95dd5eb2238eebe697db9dd063ef1 

Diff: https://reviews.apache.org/r/37091/diff/


Testing
-------

sudo make check


Thanks,

Jie Yu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message