mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jiang Yan Xu" <...@jxu.me>
Subject Re: Review Request 36956: Created a test abstraction for preparing test rootfs.
Date Tue, 04 Aug 2015 18:02:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36956/#review93921
-----------------------------------------------------------

Ship it!



src/tests/containerizer/rootfs.hpp (line 66)
<https://reviews.apache.org/r/36956/#comment148358>

    Just wanted to comment on this because this is related to a previous discussion.
    
    For `Path`, <stout/path.hpp> is not directly included and I don't think os.hpp is
explicitly "exporting" `Path` through its APIs.
    
    I am less certain about what to do with the calls to the functions under `os::`. We have
intentionally separated out these headers such as <os/stat.hpp> but in order to use
`os::mkdir` we need to include <os.hpp> which includes everything under `stout/os/`.
    
    Maybe we should continue to refactor all these basic functions out of os.hpp so we only
include os.hpp when we intentionally want to include everything.


- Jiang Yan Xu


On Aug. 3, 2015, 10:18 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36956/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2015, 10:18 a.m.)
> 
> 
> Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3179
>     https://issues.apache.org/jira/browse/MESOS-3179
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Created a test abstraction for preparing test rootfs.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 
>   src/tests/containerizer/launch_tests.cpp 73c8c5fa17936b1bab4817e9f1e691144e87c35f 
>   src/tests/containerizer/rootfs.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36956/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message