mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Toenshoff" <toensh...@me.com>
Subject Re: Review Request 36908: Added QuotaInfo Protobuf.
Date Mon, 03 Aug 2015 14:46:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review93909
-----------------------------------------------------------

Ship it!


Looks good to me.


src/Makefile.am (lines 182 - 183)
<https://reviews.apache.org/r/36908/#comment148342>

    Shall we order these as well a little?



src/Makefile.am (line 801)
<https://reviews.apache.org/r/36908/#comment148338>

    You really do not want to reorder them, huh? :)



src/Makefile.am (line 818)
<https://reviews.apache.org/r/36908/#comment148343>

    Not yours but it seems we got some spaces in here that we dont need. Hint, always have
a look at your RRs within RB as well and check for such red bars :)


- Till Toenshoff


On July 29, 2015, 4:59 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36908/
> -----------------------------------------------------------
> 
> (Updated July 29, 2015, 4:59 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3164
>     https://issues.apache.org/jira/browse/MESOS-3164
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added QuotaInfo Protobuf.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/quota.hpp PRE-CREATION 
>   include/mesos/master/quota.proto PRE-CREATION 
>   src/Makefile.am 0794969b4b147e0f837006f2f2eba6c6b28eb332 
> 
> Diff: https://reviews.apache.org/r/36908/diff/
> 
> 
> Testing
> -------
> 
> make distcheck
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message