From reviews-return-6130-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Jul 29 20:40:12 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8C7C118C04 for ; Wed, 29 Jul 2015 20:40:12 +0000 (UTC) Received: (qmail 23872 invoked by uid 500); 29 Jul 2015 20:40:12 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 23851 invoked by uid 500); 29 Jul 2015 20:40:12 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 23837 invoked by uid 99); 29 Jul 2015 20:40:12 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Jul 2015 20:40:12 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6167ED7791; Wed, 29 Jul 2015 20:40:11 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1779450493822764369==" MIME-Version: 1.0 Subject: Re: Review Request 36909: Call parent SetUp() and TearDown() in MesosZooKeeperTest. From: "Alexander Rukletsov" To: "Vinod Kone" Cc: "Alexander Rukletsov" , "haosdent huang" , "mesos" Date: Wed, 29 Jul 2015 20:40:11 -0000 Message-ID: <20150729204011.1539.50296@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Alexander Rukletsov" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/36909/ X-Sender: "Alexander Rukletsov" References: <20150729135635.1539.78187@reviews.apache.org> In-Reply-To: <20150729135635.1539.78187@reviews.apache.org> Reply-To: "Alexander Rukletsov" X-ReviewRequest-Repository: mesos --===============1779450493822764369== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36909/#review93509 ----------------------------------------------------------- src/tests/mesos.hpp (line 317) Shouldn't it come after network shutdown? https://reviews.apache.org/r/36920/ - Alexander Rukletsov On July 29, 2015, 1:56 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36909/ > ----------------------------------------------------------- > > (Updated July 29, 2015, 1:56 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-3168 > https://issues.apache.org/jira/browse/MESOS-3168 > > > Repository: mesos > > > Description > ------- > > Call parent SetUp() and TearDown() in MesosZooKeeperTest. > > > Diffs > ----- > > src/tests/mesos.hpp 192067d90aec2a114091e413e92e1ced10225afc > > Diff: https://reviews.apache.org/r/36909/diff/ > > > Testing > ------- > > make check > > > Thanks, > > haosdent huang > > --===============1779450493822764369==--