From reviews-return-6088-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Jul 29 13:59:13 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9B88918A1B for ; Wed, 29 Jul 2015 13:59:13 +0000 (UTC) Received: (qmail 41951 invoked by uid 500); 29 Jul 2015 13:59:13 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 41929 invoked by uid 500); 29 Jul 2015 13:59:13 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 41909 invoked by uid 99); 29 Jul 2015 13:59:13 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Jul 2015 13:59:13 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2D5DBD7315; Wed, 29 Jul 2015 13:59:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6376471482681176964==" MIME-Version: 1.0 Subject: Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction. From: "Jan Schlicht" To: "Joerg Schad" , "Bernd Mathiske" Cc: "Jan Schlicht" , "Mesos ReviewBot" , "mesos" Date: Wed, 29 Jul 2015 13:59:12 -0000 Message-ID: <20150729135912.1540.69095@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jan Schlicht" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/36773/ X-Sender: "Jan Schlicht" References: <20150729125943.1540.81016@reviews.apache.org> In-Reply-To: <20150729125943.1540.81016@reviews.apache.org> Reply-To: "Jan Schlicht" X-ReviewRequest-Repository: mesos --===============6376471482681176964== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/ ----------------------------------------------------------- (Updated July 29, 2015, 3:59 p.m.) Review request for mesos, Bernd Mathiske and Joerg Schad. Bugs: MESOS-3112 https://issues.apache.org/jira/browse/MESOS-3112 Repository: mesos Description ------- A linked list is used to keep cache entries in LRU-to-MRU order. Each time an existing cache entry is requested, it is moved to the back of the list. During cache eviction entries are removed from the front of the list until enough cache space can be freed. Diffs (updated) ----- docs/fetcher-cache-internals.md 327cbc3074bcc110e1250e2151dd5401ccaadb4b src/slave/containerizer/fetcher.hpp 17225072ba5c1c9a7209f2923bcf562fcb76201f src/slave/containerizer/fetcher.cpp e030deabd5e749100cbccabb256dbd4af8b2fe58 src/tests/fetcher_cache_tests.cpp bd9c406a532a85fa95a5e9cfa6003f4893191c57 Diff: https://reviews.apache.org/r/36773/diff/ Testing ------- make check Thanks, Jan Schlicht --===============6376471482681176964==--