From reviews-return-5929-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Jul 28 00:02:15 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0F68718171 for ; Tue, 28 Jul 2015 00:02:15 +0000 (UTC) Received: (qmail 82749 invoked by uid 500); 28 Jul 2015 00:02:12 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 82728 invoked by uid 500); 28 Jul 2015 00:02:12 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 82714 invoked by uid 99); 28 Jul 2015 00:02:11 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Jul 2015 00:02:11 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 225C4D6959; Tue, 28 Jul 2015 00:02:11 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6590200676660363397==" MIME-Version: 1.0 Subject: Re: Review Request 36799: Renamed Executor{Limitation, RunState} to Container{Limitation, State}. From: "Kapil Arya" To: "Benjamin Hindman" , "Jie Yu" Cc: "Mesos ReviewBot" , "mesos" Date: Tue, 28 Jul 2015 00:02:11 -0000 Message-ID: <20150728000211.28761.19921@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Kapil Arya" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/36799/ X-Sender: "Kapil Arya" References: <20150726184941.28761.12916@reviews.apache.org> In-Reply-To: <20150726184941.28761.12916@reviews.apache.org> Reply-To: "Kapil Arya" X-ReviewRequest-Repository: mesos --===============6590200676660363397== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36799/ ----------------------------------------------------------- (Updated July 27, 2015, 8:02 p.m.) Review request for mesos, Benjamin Hindman and Jie Yu. Changes ------- rebased Repository: mesos Description ------- The new names better reflect the contents since the Limitation and State are for the container. Diffs (updated) ----- include/mesos/slave/isolator.hpp 879e03e5bf49fab507b8d9904f944d950de18987 include/mesos/slave/isolator.proto 07c1c1a09d1578dd4c3abd8bb1773782b4aa9549 src/common/protobuf_utils.hpp 5c992540e29143ed51fdd06b52dbde05e4136f58 src/common/protobuf_utils.cpp bf178d2942e8f5bed3d7eff44ed5929a552ecf35 src/slave/containerizer/isolator.hpp 1482b4c9fa375bdb2607bf83334b44b97024cba8 src/slave/containerizer/isolator.cpp 9d2af8b42f37550a75eae52ef1f5c1a647131072 src/slave/containerizer/isolators/cgroups/cpushare.hpp 409a3a997a7b2c7104421f48ee1078e8fd369a2a src/slave/containerizer/isolators/cgroups/cpushare.cpp ccaf1e372c0693522aed2e0aa8d680e404faf8ef src/slave/containerizer/isolators/cgroups/mem.hpp d43ba6d3debfc6279a023bd28f584635eeb79dc3 src/slave/containerizer/isolators/cgroups/mem.cpp 70c9868dbb670278b3bb4e4322598285488851fe src/slave/containerizer/isolators/cgroups/perf_event.hpp 3796b30a56799a00f1ddbec9bd20b9203d689856 src/slave/containerizer/isolators/cgroups/perf_event.cpp a62a4e6ca573230af17781495eae63115ef28f00 src/slave/containerizer/isolators/filesystem/posix.hpp 2afc572d20acb3d31d3981d99ffe6ea45ae93dff src/slave/containerizer/isolators/filesystem/posix.cpp 5e5a896d9888375259a38dcc68d03dce6406a28e src/slave/containerizer/isolators/filesystem/shared.hpp f6ba43a6d6d3a2afb9380f05de9edaa3fe3c5936 src/slave/containerizer/isolators/filesystem/shared.cpp 4694025eb9b3adad70cc1ec7541c3d3f95fec2bc src/slave/containerizer/isolators/namespaces/pid.hpp 61db386b1d6f602edcba8a1fa251cfd12a534aca src/slave/containerizer/isolators/namespaces/pid.cpp 29be94b96ed9a3db90c88a4b60517d78e95b7144 src/slave/containerizer/isolators/network/port_mapping.hpp fb9ce9c3a33d652a6e1dda3485dde0f2d914ccac src/slave/containerizer/isolators/network/port_mapping.cpp 3f35782c9e0e458169777bab778178c524a58b2b src/slave/containerizer/isolators/posix.hpp 58d9911fef6f57dd078c533221094f9c69489fe4 src/slave/containerizer/isolators/posix/disk.hpp 86aea37d0bbf5d2e5bfc32624fe084b2e73dac1a src/slave/containerizer/isolators/posix/disk.cpp 845496c865a92946910a4e9dd50d05482503b7ef src/slave/containerizer/launcher.hpp a19b8592f943d3a2ae0337c142f54c0ada204536 src/slave/containerizer/launcher.cpp ecb33309ff0941985eebf7a94d831330076978de src/slave/containerizer/linux_launcher.hpp 28a7d35dbbbb99881486a9d63eb0aaedad15cb99 src/slave/containerizer/linux_launcher.cpp ed2e881f555d651ad1e5f1b62f32848ade09b424 src/slave/containerizer/mesos/containerizer.hpp 5155362bef9163af3fa5334be3a39b91549e1ec1 src/slave/containerizer/mesos/containerizer.cpp 11eedf30674b326ea3e1f6f71d27f9eb54126368 src/slave/containerizer/provisioner.hpp f7fb068ca5b0a8da1fb756411d59536ed7a1aec8 src/tests/containerizer/containerizer_tests.cpp a44b6e887c37e55213db068a95ab3e73a033e1ea src/tests/containerizer/isolator.hpp 8aaf88c3ea8362950e363d15cbe2b598a12f12d6 src/tests/containerizer/launcher.hpp 78216e0805eadb8eb425d9d58aae1b102a7817b5 Diff: https://reviews.apache.org/r/36799/diff/ Testing ------- make check Thanks, Kapil Arya --===============6590200676660363397==--