From reviews-return-5823-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Jul 27 00:04:42 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2C3FE18373 for ; Mon, 27 Jul 2015 00:04:42 +0000 (UTC) Received: (qmail 56192 invoked by uid 500); 27 Jul 2015 00:04:42 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 56168 invoked by uid 500); 27 Jul 2015 00:04:42 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 56154 invoked by uid 99); 27 Jul 2015 00:04:41 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Jul 2015 00:04:41 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 829EB1CF88E; Mon, 27 Jul 2015 00:04:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8239264243583925813==" MIME-Version: 1.0 Subject: Review Request 36831: Allowed Isolator::prepare to return a list of CommandInfos. From: "Kapil Arya" To: "Benjamin Hindman" , "Jie Yu" Cc: "mesos" Date: Mon, 27 Jul 2015 00:04:40 -0000 Message-ID: <20150727000440.28760.7338@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Kapil Arya" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/36831/ X-Sender: "Kapil Arya" Reply-To: "Kapil Arya" X-ReviewRequest-Repository: mesos --===============8239264243583925813== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36831/ ----------------------------------------------------------- Review request for mesos, Benjamin Hindman and Jie Yu. Repository: mesos Description ------- Previously, the Isolators had to join all the preparation commands into a single command using `&&`. Now they can pass each command separately. Diffs ----- include/mesos/slave/isolator.proto 07c1c1a09d1578dd4c3abd8bb1773782b4aa9549 src/slave/containerizer/isolators/filesystem/shared.cpp 4694025eb9b3adad70cc1ec7541c3d3f95fec2bc src/slave/containerizer/isolators/namespaces/pid.cpp 29be94b96ed9a3db90c88a4b60517d78e95b7144 src/slave/containerizer/mesos/containerizer.cpp 11eedf30674b326ea3e1f6f71d27f9eb54126368 src/tests/containerizer/containerizer_tests.cpp a44b6e887c37e55213db068a95ab3e73a033e1ea src/tests/containerizer/isolator_tests.cpp 59f08c0c175ea800ba23d85666d20b6a7b6d07d6 Diff: https://reviews.apache.org/r/36831/diff/ Testing ------- make check. Thanks, Kapil Arya --===============8239264243583925813==--