----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36827/#review93062 ----------------------------------------------------------- Ship it! Built on OSX, ran sudo make check. 3rdparty/libprocess/src/libevent.cpp (line 198) Do you think it would make sense to make the error message more descriptive? Maybe something like 'Libevent must be compiled with either pthread or Windows thread support'? Thanks! - Artem Harutyunyan On July 26, 2015, 12:53 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36827/ > ----------------------------------------------------------- > > (Updated July 26, 2015, 12:53 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park. > > > Bugs: MESOS-3119 > https://issues.apache.org/jira/browse/MESOS-3119 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/src/libevent.cpp 1f175a4ae83391152d064779c6ab69d31cbaf867 > 3rdparty/libprocess/src/openssl.cpp 6aa2a4db8d64011d0fde6ff0cf4b144c41949d39 > > Diff: https://reviews.apache.org/r/36827/diff/ > > > Testing > ------- > > make check. > Waiting on validation from someone with an OSX build > > > Thanks, > > Joris Van Remoortere > >