From reviews-return-5452-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Jul 21 19:40:43 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0AA7618C67 for ; Tue, 21 Jul 2015 19:40:43 +0000 (UTC) Received: (qmail 43525 invoked by uid 500); 21 Jul 2015 19:40:43 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 43518 invoked by uid 500); 21 Jul 2015 19:40:43 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 43502 invoked by uid 99); 21 Jul 2015 19:40:42 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Jul 2015 19:40:42 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id EF884BE236; Tue, 21 Jul 2015 19:40:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8287716394157162652==" MIME-Version: 1.0 Subject: Re: Review Request 36620: WIP Added Non-Freezeer Task Killer. From: "Timothy Chen" To: "Timothy Chen" Cc: "Joerg Schad" , "mesos" Date: Tue, 21 Jul 2015 19:40:40 -0000 Message-ID: <20150721194040.10541.99597@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Timothy Chen" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/36620/ X-Sender: "Timothy Chen" References: <20150721171808.10541.23257@reviews.apache.org> In-Reply-To: <20150721171808.10541.23257@reviews.apache.org> Reply-To: "Timothy Chen" X-ReviewRequest-Repository: mesos --===============8287716394157162652== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review92459 ----------------------------------------------------------- src/linux/cgroups.cpp (line 1671) It's very odd to see the failure message set here but then a lot more attempts to try to set it in the finished callback. How about having a failed method that sets the failure and another finished callback that is what you have? src/linux/cgroups.cpp (line 1683) Very wierd identation? src/linux/cgroups.cpp (line 1686) //check -> // Check src/linux/cgroups.cpp (line 1688) one more space to the right src/linux/cgroups.cpp (line 1708) extra space between "the" and "pids" - Timothy Chen On July 21, 2015, 5:18 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36620/ > ----------------------------------------------------------- > > (Updated July 21, 2015, 5:18 p.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-3086 > https://issues.apache.org/jira/browse/MESOS-3086 > > > Repository: mesos > > > Description > ------- > > WIP Added Non-Freezeer Task Killer. > > > Diffs > ----- > > src/linux/cgroups.cpp b7d11ac4eb8b78664c8c7bd7a5b0d566b5bf2f0e > > Diff: https://reviews.apache.org/r/36620/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Joerg Schad > > --===============8287716394157162652==--