From reviews-return-5258-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Jul 17 01:36:49 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3F47718A62 for ; Fri, 17 Jul 2015 01:36:49 +0000 (UTC) Received: (qmail 32433 invoked by uid 500); 17 Jul 2015 01:36:49 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 32405 invoked by uid 500); 17 Jul 2015 01:36:49 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 32385 invoked by uid 99); 17 Jul 2015 01:36:48 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Jul 2015 01:36:48 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A5B84A90AD; Fri, 17 Jul 2015 01:36:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4740225534626284582==" MIME-Version: 1.0 Subject: Re: Review Request 34137: Add support for container image provisioners. From: "Jie Yu" To: "Vinod Kone" , "Timothy Chen" , "Paul Brett" , "Chi Zhang" Cc: "mesos" , "Jie Yu" , "Ian Downes" Date: Fri, 17 Jul 2015 01:36:47 -0000 Message-ID: <20150717013647.17362.90637@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jie Yu" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/34137/ X-Sender: "Jie Yu" References: <20150712044722.1573.66282@reviews.apache.org> In-Reply-To: <20150712044722.1573.66282@reviews.apache.org> Reply-To: "Jie Yu" X-ReviewRequest-Repository: mesos --===============4740225534626284582== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34137/#review92000 ----------------------------------------------------------- Tim, I probably wound wait for Vinod's shipit before committing this. There seems to be a bug in the code as well (besides the obvious broken build issue). src/slave/containerizer/mesos/containerizer.cpp (line 629) Hum, looks like a bug since, for example, slaveId is a reference and will be invalid when the lambda is called. In general, I think we should avoid using [=] for lambdas because its dangeous! I would prefer we resort to our old style defer style (e.g., introduce `_provision`). src/slave/containerizer/mesos/containerizer.cpp (lines 636 - 642) No test for checkpointing??? src/slave/containerizer/mesos/containerizer.cpp (line 1236) `_____destroy` is a void function. We should do: ``` _____destroy(...); return; ``` src/slave/containerizer/mesos/containerizer.cpp (line 1247) Ditto. src/slave/containerizer/mesos/containerizer.cpp (line 1268) s/cleanup/future/ src/slave/containerizer/provisioner.hpp (lines 37 - 38) This should be #include src/slave/containerizer/provisioner.hpp (lines 52 - 54) Recover containers? What container? This is a little misleading. How about ``` Recover root filesystems for containers... ```` src/slave/containerizer/provisioner.cpp (line 24) Where is this? This won't compile! - Jie Yu On July 12, 2015, 4:47 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34137/ > ----------------------------------------------------------- > > (Updated July 12, 2015, 4:47 a.m.) > > > Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > The MesosContainerizer can optionally provision a root filesystem for the containers. > > > Diffs > ----- > > include/mesos/slave/isolator.hpp ef2205dd7f4619e53e6cca7cac301f874d08c036 > src/Makefile.am e5b5d36f0ac160e5a3a9fdc50b31c060a413ce2c > src/slave/containerizer/mesos/containerizer.hpp 3ac2387eabded61c897a5016655aae10cd1bca91 > src/slave/containerizer/mesos/containerizer.cpp 47d146125dfd4ea909e7ec9d94f41cfa11d035e5 > src/slave/containerizer/provisioner.hpp PRE-CREATION > src/slave/containerizer/provisioner.cpp PRE-CREATION > src/slave/flags.hpp 26c778db2303167369af8675fe0441a00a1e9151 > src/slave/flags.cpp 8632677ebbdbfef8ffa45204b6f63a700baff7f3 > src/slave/paths.hpp 00476f107ed8233123a6eab0925c9f28aac0a86f > src/slave/paths.cpp 0741616b656e947cb460dd6ee6a9a4852be001c2 > src/slave/state.hpp bb0eee78e118210ccd7fcbd909029412ff106128 > src/slave/state.cpp f8a9514f52bf9f886171c2a0e674e5a89f8dbea7 > src/tests/containerizer_tests.cpp 0cdb2d2a3f19a4835e85c6b040759019b03f051e > > Diff: https://reviews.apache.org/r/34137/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > > --===============4740225534626284582==--