From reviews-return-5090-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Jul 15 00:11:57 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B62B118F51 for ; Wed, 15 Jul 2015 00:11:57 +0000 (UTC) Received: (qmail 64201 invoked by uid 500); 15 Jul 2015 00:11:57 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 64178 invoked by uid 500); 15 Jul 2015 00:11:57 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 64163 invoked by uid 99); 15 Jul 2015 00:11:57 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Jul 2015 00:11:57 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 527F5BBA11; Wed, 15 Jul 2015 00:11:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5827939121155898624==" MIME-Version: 1.0 Subject: Re: Review Request 36389: Enable remote execution of arbitrary command. From: "Jie Yu" To: "Benjamin Hindman" , "Cody Maloney" Cc: "mesos" , "Jie Yu" , "Marco Massenzio" Date: Wed, 15 Jul 2015 00:11:55 -0000 Message-ID: <20150715001155.17362.36117@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jie Yu" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/36389/ X-Sender: "Jie Yu" References: <20150714232157.17363.64751@reviews.apache.org> In-Reply-To: <20150714232157.17363.64751@reviews.apache.org> Reply-To: "Jie Yu" X-ReviewRequest-Repository: mesos --===============5827939121155898624== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On July 14, 2015, 11:21 p.m., Jie Yu wrote: > > Discussed with Cody on the design doc. Does it make sense to implement that as an anonymous module? > > Marco Massenzio wrote: > Can you please elaborate on the pros/cons of doing so? > thanks! Please refer to the design doc for the discussion. To summerize, I am not convinced that this functionality should belong to Mesos. It could be a standalone service (possibly launched by Mesos) that runs on each slave. ALso, what if the slave is down? Do you still need some way to access the box? - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36389/#review91678 ----------------------------------------------------------- On July 14, 2015, 11:20 p.m., Marco Massenzio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36389/ > ----------------------------------------------------------- > > (Updated July 14, 2015, 11:20 p.m.) > > > Review request for mesos, Benjamin Hindman and Cody Maloney. > > > Bugs: MESOS-2830 > https://issues.apache.org/jira/browse/MESOS-2830 > > > Repository: mesos > > > Description > ------- > > Jira: MESOS-2830 > > Under certain (maintenance) circumnstance, it may be necessary > (or desirable) to execute arbitrary operator's commands on the > slave (the entire fleet or a subset thereof) bypassing the Mesos > Task execution mechanism; this may typically be necessary for > maintenance and/or emergency actions. > > This patch adds an HTTP endpoint (/execute) which accepts a > JSON-encoded CommandInfo structure and executes the given > command (with optional arguments). > > The output of the command (along with potentially any stderr > messages) is returned JSON-encoded in the Response. > > For more details, see the design doc at: > https://goo.gl/4npTMU > > > Diffs > ----- > > src/slave/flags.hpp 26c778db2303167369af8675fe0441a00a1e9151 > src/slave/flags.cpp 8632677ebbdbfef8ffa45204b6f63a700baff7f3 > src/slave/main.cpp 8008430e98773d8be9ba5ac6385cffb2e351932a > src/slave/slave.hpp dec4ca8323e151a6d0f9139214ff0ef6e3e3375a > src/slave/slave.cpp 2119b5176aa7cfb7b0b551d4d4f65ee12818b9e4 > > Diff: https://reviews.apache.org/r/36389/diff/ > > > Testing > ------- > > make check > > lots of manual testing (using Postman, REST client) > > > Thanks, > > Marco Massenzio > > --===============5827939121155898624==--