From reviews-return-5026-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Jul 13 19:37:22 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E41AC1872B for ; Mon, 13 Jul 2015 19:37:21 +0000 (UTC) Received: (qmail 40327 invoked by uid 500); 13 Jul 2015 19:37:21 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 40304 invoked by uid 500); 13 Jul 2015 19:37:21 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 40289 invoked by uid 99); 13 Jul 2015 19:37:21 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Jul 2015 19:37:21 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BA581BB89C; Mon, 13 Jul 2015 19:37:20 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0508392191027098531==" MIME-Version: 1.0 Subject: Re: Review Request 36453: Ignored subsequent calls to 'resourceOffers' in 'ReservationTest.CompatibleCheckpointedResources' test. From: "Jie Yu" To: "Ben Mahler" , "Jie Yu" Cc: "Michael Park" , "mesos" Date: Mon, 13 Jul 2015 19:37:20 -0000 Message-ID: <20150713193720.17363.17477@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jie Yu" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/36453/ X-Sender: "Jie Yu" References: <20150713192955.17362.83937@reviews.apache.org> In-Reply-To: <20150713192955.17362.83937@reviews.apache.org> Reply-To: "Jie Yu" X-ReviewRequest-Repository: mesos --===============0508392191027098531== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36453/#review91511 ----------------------------------------------------------- Ship it! src/tests/reservation_tests.cpp (line 928) Please add a comment since it's not quite obvious. .WillRepeatedly(Return()); // Ignore subsequent offers. - Jie Yu On July 13, 2015, 7:29 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36453/ > ----------------------------------------------------------- > > (Updated July 13, 2015, 7:29 p.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Bugs: MESOS-3034 > https://issues.apache.org/jira/browse/MESOS-3034 > > > Repository: mesos > > > Description > ------- > > Ignored subsequent calls to 'resourceOffers' in 'ReservationTest.CompatibleCheckpointedResources' test. > > > Diffs > ----- > > src/tests/reservation_tests.cpp 99bf393ed4e806dee13518cfbd2d44d740285c2c > > Diff: https://reviews.apache.org/r/36453/diff/ > > > Testing > ------- > > I was able to reproduce more reliably after changing `master.allocation_interval` to `Milliseconds(1)` and running `GTEST_FILTER="ReservationTest.CompatibleCheckpointedResources" ./bin/mesos-tests.sh --gtest_repeat=1000`. > > Ran the above command with the fix and observed that it passes. > > > Thanks, > > Michael Park > > --===============0508392191027098531==--