From reviews-return-4929-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Jul 10 21:10:18 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8E69B18DD5 for ; Fri, 10 Jul 2015 21:10:18 +0000 (UTC) Received: (qmail 15735 invoked by uid 500); 10 Jul 2015 21:10:18 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 15711 invoked by uid 500); 10 Jul 2015 21:10:18 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 15686 invoked by uid 99); 10 Jul 2015 21:10:18 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Jul 2015 21:10:18 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7A92BBADCA; Fri, 10 Jul 2015 21:10:17 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5483316535960099962==" MIME-Version: 1.0 Subject: Re: Review Request 36106: cgroups: added cpuacct subsystem From: "Timothy Chen" To: "Joris Van Remoortere" , "Timothy Chen" , "Jie Yu" , "Ian Downes" Cc: "mesos" , "Jojy Varghese" Date: Fri, 10 Jul 2015 21:10:17 -0000 Message-ID: <20150710211017.1573.33748@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Timothy Chen" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/36106/ X-Sender: "Timothy Chen" References: <20150710204705.1572.97487@reviews.apache.org> In-Reply-To: <20150710204705.1572.97487@reviews.apache.org> Reply-To: "Timothy Chen" X-ReviewRequest-Repository: mesos --===============5483316535960099962== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36106/#review91343 ----------------------------------------------------------- src/linux/cgroups.hpp (line 438) benm: Remove 1 space. src/linux/cgroups.cpp (line 2003) benm: s/std::string/string/g src/linux/cgroups.cpp (line 2004) ditto src/linux/cgroups.cpp (line 2022) benm: s/Error getting/Failed to get/g Also we should use ErrnoError as well. src/linux/cgroups.cpp (line 2030) benm: All the error messages in this file follows the "Failed to..." instead of "Error..." message, we should be consistent. src/tests/cgroups_tests.cpp (line 62) benm: Remove alias src/tests/cgroups_tests.cpp (line 1199) benm: Remove storing result and just ASSERT_SOME(cgroups::cpuacct::stat(hierarchy, TEST_CGROUPS_ROOT)); src/tests/cgroups_tests.cpp (line 1203) benm: AWAIT_READY(cgroups::destroy(hierarchy, TEST_CGROUPS_ROOT)); - Timothy Chen On July 10, 2015, 8:47 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36106/ > ----------------------------------------------------------- > > (Updated July 10, 2015, 8:47 p.m.) > > > Review request for mesos, Ian Downes, Jie Yu, Joris Van Remoortere, and Timothy Chen. > > > Bugs: MESOS-2961 > https://issues.apache.org/jira/browse/MESOS-2961 > > > Repository: mesos > > > Description > ------- > > cgroups implementation does not have a cpuacct subsystem implementation as of > today. Adding the implementation for stat function. > > Changes: > - added Stats class to encapsulate cpuacct.stat data > - added implementation for cpuacct::stats > - added unit tests > > Jira: MESOS-2961 > > > Diffs > ----- > > src/linux/cgroups.hpp 73b98317880eea3d6a2ba37ac56d1f7e3600ba94 > src/linux/cgroups.cpp 4c006d0c7382b940a83359d636c0d48952cdbb00 > src/tests/cgroups_tests.cpp 475f48a474eea708f98d8c0300862351a2d4379a > > Diff: https://reviews.apache.org/r/36106/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jojy Varghese > > --===============5483316535960099962==--