From reviews-return-4717-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Jul 8 00:28:03 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 80DA518844 for ; Wed, 8 Jul 2015 00:28:03 +0000 (UTC) Received: (qmail 68982 invoked by uid 500); 8 Jul 2015 00:28:03 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 68957 invoked by uid 500); 8 Jul 2015 00:28:03 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 68932 invoked by uid 99); 8 Jul 2015 00:28:03 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Jul 2015 00:28:03 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 04695A8F9F; Wed, 8 Jul 2015 00:28:03 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8792292532132591616==" MIME-Version: 1.0 Subject: Re: Review Request 34139: AppC image discovery. From: "Jiang Yan Xu" To: "Vinod Kone" , "Timothy Chen" , "Paul Brett" , "Chi Zhang" Cc: "Jiang Yan Xu" , "mesos" , "Ian Downes" Date: Wed, 08 Jul 2015 00:28:03 -0000 Message-ID: <20150708002803.1572.22657@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jiang Yan Xu" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/34139/ X-Sender: "Jiang Yan Xu" References: <20150707194257.1572.68054@reviews.apache.org> In-Reply-To: <20150707194257.1572.68054@reviews.apache.org> Reply-To: "Jiang Yan Xu" X-ReviewRequest-Repository: mesos --===============8792292532132591616== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34139/#review90830 ----------------------------------------------------------- src/slave/containerizer/provisioners/appc/discovery.hpp (lines 43 - 46) Some comments explaining that the return value is a URI string would be nice. src/slave/containerizer/provisioners/appc/discovery.hpp (line 46) The `id` is not use in this review and not specified in https://github.com/appc/spec/blob/master/spec/discovery.md I assume its the sha512 but is it used during discovery? src/slave/containerizer/provisioners/appc/discovery.hpp (line 79) No need for the trailing `;` src/slave/containerizer/provisioners/appc/discovery.cpp (line 21) Kill empty line. src/slave/containerizer/provisioners/appc/discovery.cpp (line 60) canonicalize() not introduced until /r/34142/. Is there anything else outside discovery that uses the method? Can it be moved to class `Discovery` (so we don't have to deal with cyclic review dependency)? src/slave/containerizer/provisioners/appc/discovery.cpp (line 90) FWIW https://github.com/appc/spec/blob/master/spec/discovery.md uses https exclusively. src/slave/flags.cpp (line 63) List all supported values? src/slave/flags.cpp (line 68) State that this is only for local discovery? The sentences already mentions 'local images' but I think --appc_discovery=local is more explict in telling what the operator should do. - Jiang Yan Xu On July 7, 2015, 12:42 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34139/ > ----------------------------------------------------------- > > (Updated July 7, 2015, 12:42 p.m.) > > > Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Local and simple discovery only. > > > Diffs > ----- > > src/Makefile.am e7de0f3d1a5efeaef47d5074defe3b40db94f573 > src/slave/containerizer/provisioners/appc/discovery.hpp PRE-CREATION > src/slave/containerizer/provisioners/appc/discovery.cpp PRE-CREATION > src/slave/flags.hpp 7634e368c72e83932dcd992d78eaca146326606b > src/slave/flags.cpp cbf431eb0627bdaf07241cc0fc4630df06fb20e2 > > Diff: https://reviews.apache.org/r/34139/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > > --===============8792292532132591616==--