From reviews-return-4653-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Jul 7 18:50:29 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BA08618A78 for ; Tue, 7 Jul 2015 18:50:29 +0000 (UTC) Received: (qmail 77775 invoked by uid 500); 7 Jul 2015 18:50:29 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 77750 invoked by uid 500); 7 Jul 2015 18:50:29 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 77730 invoked by uid 99); 7 Jul 2015 18:50:29 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Jul 2015 18:50:29 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2EB62A8DFC; Tue, 7 Jul 2015 18:50:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7892466715011208458==" MIME-Version: 1.0 Subject: Re: Review Request 36269: Update CHANGELOG to reflect obsolete code cleanup From: "Jiang Yan Xu" To: "Adam B" Cc: "Jiang Yan Xu" , "Vinod Kone" , "mesos" Date: Tue, 07 Jul 2015 18:50:29 -0000 Message-ID: <20150707185029.1572.8468@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jiang Yan Xu" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/36269/ X-Sender: "Jiang Yan Xu" References: <20150707184017.1572.6585@reviews.apache.org> In-Reply-To: <20150707184017.1572.6585@reviews.apache.org> Reply-To: "Jiang Yan Xu" X-ReviewRequest-Repository: mesos --===============7892466715011208458== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On July 7, 2015, 11:40 a.m., Vinod Kone wrote: > > CHANGELOG, line 337 > > > > > > I would just put this under deprecations section. > > > > Also, mind updating MESOS-2058 in deprecation section to do s/deprecate/remove/ because its been removed. Adam is against putting MESOS-2640 in 0.23.0 because it's committed after rc1 is cut. This review doesn't even need to land now. s/deprecate/remove/ on MESOS-2058 can be done separately. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36269/#review90756 ----------------------------------------------------------- On July 7, 2015, 10:59 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36269/ > ----------------------------------------------------------- > > (Updated July 7, 2015, 10:59 a.m.) > > > Review request for mesos and Adam B. > > > Repository: mesos > > > Description > ------- > > Per Vinod's comment on /r/36005 > > The `**Cleanup` section makes sense? > > > Diffs > ----- > > CHANGELOG 433924a0e614f061c448a8e85d0a2825567150dc > > Diff: https://reviews.apache.org/r/36269/diff/ > > > Testing > ------- > > > Thanks, > > Jiang Yan Xu > > --===============7892466715011208458==--