From reviews-return-4640-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Jul 7 17:54:26 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1C877187EE for ; Tue, 7 Jul 2015 17:54:26 +0000 (UTC) Received: (qmail 17671 invoked by uid 500); 7 Jul 2015 17:54:26 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 17646 invoked by uid 500); 7 Jul 2015 17:54:26 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 17628 invoked by uid 99); 7 Jul 2015 17:54:25 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Jul 2015 17:54:25 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 96772A8DA3; Tue, 7 Jul 2015 17:54:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1838417359398554404==" MIME-Version: 1.0 Subject: Re: Review Request 35981: Added persistent volume user guide. From: "Jie Yu" To: "Adam B" , "Jie Yu" , "Timothy Chen" Cc: "Michael Park" , "mesos" Date: Tue, 07 Jul 2015 17:54:25 -0000 Message-ID: <20150707175425.1573.72436@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jie Yu" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/35981/ X-Sender: "Jie Yu" References: <20150630001451.13308.14745@reviews.apache.org> In-Reply-To: <20150630001451.13308.14745@reviews.apache.org> Reply-To: "Jie Yu" X-ReviewRequest-Repository: mesos --===============1838417359398554404== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On June 30, 2015, 12:14 a.m., Adam B wrote: > > docs/persistent-volume.md, line 56 > > > > > > Can a volume/reservation created by one framework principal only be destroyed/unreserved by a framework scheduler using the same principal? If the principal is different, then the operation would fail, even if the role or even frameworkId is identical? We only look at the principal of an framework or an operator. The role does not matter because an operator does not have a role. The frameworkId is also irrelavent because framework B can unreserve/destroy a reservation/volume created by framework B as long as ACL allows it. > On June 30, 2015, 12:14 a.m., Adam B wrote: > > docs/persistent-volume.md, lines 67-69 > > > > > > You might need a blank line preceding this, and/or some indentation for it to show up as a numbered list. Doesn't render properly as is. > > > > Unique per role per slave? So I could use the same volumeId for related volume instances (e.g. my 'logging' or 'data' volumes), up to a max of one per slave? But if I happen to launch another executor/task on a slave where one of those volumes is already created/mounted, then I have to rename it ('data2')? Yes, this is in the design doc. Persistent volumes can be shared within a role, so it has to be unique per role. > On June 30, 2015, 12:14 a.m., Adam B wrote: > > docs/persistent-volume.md, lines 120-122 > > > > > > Any chance it could return the host_path too? Or do I have to go digging through slave logs to figure out where my volume was created? Why the framework wants to know that? This is similar to sandbox. Do we have a way to let the framework know about the location of the sandbox? - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35981/#review89827 ----------------------------------------------------------- On July 7, 2015, 12:34 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35981/ > ----------------------------------------------------------- > > (Updated July 7, 2015, 12:34 p.m.) > > > Review request for mesos, Adam B, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-2405 > https://issues.apache.org/jira/browse/MESOS-2405 > > > Repository: mesos > > > Description > ------- > > The Github rendered version is available [here]( https://github.com/mesosphere/mesos/blob/user-docs/docs/persistent-volume.md) > > > Diffs > ----- > > docs/persistent-volume.md PRE-CREATION > > Diff: https://reviews.apache.org/r/35981/diff/ > > > Testing > ------- > > Documentation. > > > Thanks, > > Michael Park > > --===============1838417359398554404==--