From reviews-return-4552-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Jul 6 21:52:00 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4F66518BE5 for ; Mon, 6 Jul 2015 21:52:00 +0000 (UTC) Received: (qmail 31314 invoked by uid 500); 6 Jul 2015 21:52:00 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 31290 invoked by uid 500); 6 Jul 2015 21:52:00 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 37684 invoked by uid 99); 6 Jul 2015 20:52:00 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Jul 2015 20:52:00 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 46C7CB3349; Mon, 6 Jul 2015 20:51:59 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4881983665067263241==" MIME-Version: 1.0 Subject: Re: Review Request 36024: Refactored OSNetUri tests for fetcher to avoid code copy/pasting. From: "Artem Harutyunyan" To: "Joris Van Remoortere" Cc: "Artem Harutyunyan" , "Mesos ReviewBot" , "mesos" Date: Mon, 06 Jul 2015 20:51:59 -0000 Message-ID: <20150706205159.8753.98919@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Artem Harutyunyan" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/36024/ X-Sender: "Artem Harutyunyan" References: <20150630232532.13308.9791@reviews.apache.org> In-Reply-To: <20150630232532.13308.9791@reviews.apache.org> Reply-To: "Artem Harutyunyan" X-ReviewRequest-Repository: mesos --===============4881983665067263241== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36024/ ----------------------------------------------------------- (Updated July 6, 2015, 1:51 p.m.) Review request for mesos and Joris Van Remoortere. Changes ------- Fixed compile error. Merged changes from parent review. Bugs: MESOS-2862 https://issues.apache.org/jira/browse/MESOS-2862 Repository: mesos Description ------- Refactored OSNetUri tests for fetcher to avoid code copy/pasting. Diffs (updated) ----- src/tests/fetcher_tests.cpp ae10c420f7dddb8650377c91b5343591e8560392 Diff: https://reviews.apache.org/r/36024/diff/ Testing ------- # This is a test case refactoring. $ make check Thanks, Artem Harutyunyan --===============4881983665067263241==--