From reviews-return-4410-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Jul 2 23:36:25 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 97CE6179E5 for ; Thu, 2 Jul 2015 23:36:25 +0000 (UTC) Received: (qmail 55716 invoked by uid 500); 2 Jul 2015 23:36:25 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 55690 invoked by uid 500); 2 Jul 2015 23:36:25 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 55676 invoked by uid 99); 2 Jul 2015 23:36:25 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Jul 2015 23:36:25 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3AA73B1DEC; Thu, 2 Jul 2015 23:36:24 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4211327539631263729==" MIME-Version: 1.0 Subject: Re: Review Request 36048: Updated authorizer to allow for modularize implementations From: "Alexander Rojas" To: "Alexander Rojas" , "mesos" Date: Thu, 02 Jul 2015 23:36:24 -0000 Message-ID: <20150702233624.13307.23777@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Alexander Rojas" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/36048/ X-Sender: "Alexander Rojas" References: <20150702233408.13307.8830@reviews.apache.org> In-Reply-To: <20150702233408.13307.8830@reviews.apache.org> Reply-To: "Alexander Rojas" X-ReviewRequest-Repository: mesos --===============4211327539631263729== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ ----------------------------------------------------------- (Updated July 3, 2015, 1:36 a.m.) Review request for mesos and Till Toenshoff. Bugs: MESOS-2945 https://issues.apache.org/jira/browse/MESOS-2945 Repository: mesos Description ------- Breaks the declaration of the `Authorizer` interface and its default implementation `LocalAuthorizer` in different files. Makes the `Authorizer` interface declaration public. Following the patter in the `Authenticator` it generates a default constructor which is required when writing a `TypeTest` in a follow up patch, and an `initialize` method. Other changes are just updates to allow for compilation. Diffs ----- include/mesos/authorizer/authorizer.hpp PRE-CREATION include/mesos/authorizer/authorizer.proto PRE-CREATION include/mesos/mesos.proto 3dd4a5b7a4b3bc56bdc690d6adf05f88c0d28273 include/mesos/type_utils.hpp e7bfe8ca60af945e76b5d85ab37cc97b17ff1b4a src/Makefile.am addb63f615f16ae6b25f745b2e79fd9fc0e27851 src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f src/master/http.cpp 2be613b2e4c913b74c12d0d8f2d0e25da3cd3656 src/master/main.cpp 2624b7ea4920a534c98f5dfbf9286c54c50f11a9 src/master/master.hpp fb4d6fac85e284987ec8fbf6949b5023875573fb src/master/master.cpp c5a4875f0d43c5091ae9a52c6b1d04105dfa3914 src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/cluster.hpp cfe7ef0c7a6dc62cddc3e5f5b5b28c8bcb2bed26 src/tests/mesos.hpp 9157ac079808d2686592e54ea26a26e6a0825ed3 src/tests/mesos.cpp 5eab6dea6058865847425ab8d31708c92c6f098a Diff: https://reviews.apache.org/r/36048/diff/ Testing ------- make check Thanks, Alexander Rojas --===============4211327539631263729==--