| Ben Mahler |
Re: Review Request 36958: Fixed a bug in authentication validation. |
Fri, 31 Jul, 00:54 |
| Benjamin Hindman |
Re: Review Request 36074: MESOS-2973: Allow SSL tests to run using gtest_repeat. |
Wed, 01 Jul, 23:15 |
| Benjamin Hindman |
Re: Review Request 36061: Slave exits gracefully on DNS lookup failure. |
Thu, 02 Jul, 00:12 |
| Benjamin Hindman |
Re: Review Request 36078: Refactored Call message to include Subscribe message. |
Thu, 02 Jul, 00:32 |
| Benjamin Hindman |
Re: Review Request 36116: MESOS-2965: Add implicit conversion from Path to std::string. |
Mon, 06 Jul, 02:36 |
| Benjamin Hindman |
Re: Review Request 36116: MESOS-2965: Add implicit conversion from Path to std::string. |
Mon, 06 Jul, 02:38 |
| Benjamin Hindman |
Review Request 36189: Add strings::Mode to strings::trim. |
Mon, 06 Jul, 02:54 |
| Benjamin Hindman |
Re: Review Request 35755: Changed fetcher to handle leading whitespace in URLs. |
Mon, 06 Jul, 03:02 |
| Benjamin Hindman |
Re: Review Request 32384: Adding perf check to configure |
Mon, 06 Jul, 03:41 |
| Benjamin Hindman |
Re: Review Request 32384: Adding perf check to configure |
Mon, 06 Jul, 03:42 |
| Benjamin Hindman |
Re: Review Request 32543: Documented problem and solution with slave recovery and systemd settings. |
Mon, 06 Jul, 04:24 |
| Benjamin Hindman |
Re: Review Request 32543: Documented problem and solution with slave recovery and systemd settings. |
Mon, 06 Jul, 04:26 |
| Benjamin Hindman |
Re: Review Request 36189: Add strings::Mode to strings::trim. |
Mon, 06 Jul, 15:29 |
| Benjamin Hindman |
Re: Review Request 36068: MESOS-2966: Fix 'peer()' call for ssl socket. |
Mon, 06 Jul, 16:23 |
| Benjamin Hindman |
Re: Review Request 35287: Rename Option<T>::get(const T& _t) to getOrElse() and refactor original functions (stout) |
Mon, 06 Jul, 19:51 |
| Benjamin Hindman |
Re: Review Request 35286: Rename Option<T>::get(const T& _t) to getOrElse() and refactor original functions (libprocess) |
Mon, 06 Jul, 19:51 |
| Benjamin Hindman |
Re: Review Request 35285: Rename Option<T>::get(const T& _t) to getOrElse() and refactor original functions (mesos) |
Mon, 06 Jul, 19:51 |
| Benjamin Hindman |
Re: Review Request 36245: Fix compilation error for clang-3.5 type deduction error. |
Tue, 07 Jul, 13:30 |
| Benjamin Hindman |
Re: Review Request 36277: MESOS-3002: Fix getOrElse compilation error for network isolator. |
Tue, 07 Jul, 21:51 |
| Benjamin Hindman |
Re: Review Request 36267: MESOS-2943: Add comment for explicit return type. |
Tue, 07 Jul, 21:54 |
| Benjamin Hindman |
Re: Review Request 36246: SSL: Fix connection issue on OSX. |
Tue, 07 Jul, 21:56 |
| Benjamin Hindman |
Re: Review Request 36275: MESOS-3005: Fix SSL test hostname dependency. |
Tue, 07 Jul, 22:08 |
| Benjamin Hindman |
Re: Review Request 36275: MESOS-3005: Fix SSL test hostname dependency. |
Tue, 07 Jul, 22:08 |
| Benjamin Hindman |
Re: Review Request 36282: Remove os environment for docker executor enviornment setup. |
Tue, 07 Jul, 22:16 |
| Benjamin Hindman |
Re: Review Request 23784: Missing Apache headers for stout |
Thu, 09 Jul, 21:55 |
| Benjamin Hindman |
Re: Review Request 23783: Missing Apache headers for libprocess |
Thu, 09 Jul, 22:00 |
| Benjamin Hindman |
Re: Review Request 36218: Doxygen styleguide revisions based on conversation from https://reviews.apache.org/r/36193/. |
Thu, 09 Jul, 22:09 |
| Benjamin Hindman |
Re: Review Request 36273: Doxygen-ification of comments in libprocess process headers. |
Thu, 09 Jul, 22:10 |
| Benjamin Hindman |
Re: Review Request 36226: Missing Apache headers for libprocess 3rdparty |
Thu, 09 Jul, 22:16 |
| Benjamin Hindman |
Re: Review Request 36197: Documented "how to become a committer". |
Thu, 09 Jul, 22:25 |
| Benjamin Hindman |
Re: Review Request 36450: Added an Address protobuf message for consistent address information. |
Mon, 13 Jul, 20:18 |
| Benjamin Hindman |
Re: Review Request 35755: Changed fetcher to handle leading whitespace in URLs. |
Sat, 18 Jul, 21:22 |
| Benjamin Hindman |
Re: Review Request 36574: Added helper testing functions for Labels. |
Sat, 18 Jul, 22:01 |
| Benjamin Hindman |
Review Request 36600: Fixes for NsTest on Ubuntu. |
Sun, 19 Jul, 17:38 |
| Benjamin Hindman |
Review Request 36601: Fixed UserCgroupIsolatorTest to be more explicit. |
Sun, 19 Jul, 17:38 |
| Benjamin Hindman |
Review Request 36602: Fixed cgroups test to ignore output ordering. |
Sun, 19 Jul, 17:39 |
| Benjamin Hindman |
Review Request 36603: Cleaned up 'perf' related tests to work on Ubuntu 14.04. |
Sun, 19 Jul, 17:40 |
| Benjamin Hindman |
Review Request 36604: Preemptively fail tests if previous invocations failed. |
Sun, 19 Jul, 17:40 |
| Benjamin Hindman |
Re: Review Request 36527: Fix cgroup tests to not verify order. |
Sun, 19 Jul, 17:49 |
| Benjamin Hindman |
Re: Review Request 36603: Cleaned up 'perf' related tests to work on Ubuntu 14.04. |
Sun, 19 Jul, 17:50 |
| Benjamin Hindman |
Review Request 36605: Cleaned up 'perf' related tests to work on Ubuntu 14.04. |
Sun, 19 Jul, 17:54 |
| Benjamin Hindman |
Re: Review Request 36604: Preemptively fail tests if previous invocations failed. |
Sun, 19 Jul, 17:54 |
| Benjamin Hindman |
Re: Review Request 36605: Cleaned up 'perf' related tests to work on Ubuntu 14.04. |
Sun, 19 Jul, 18:04 |
| Benjamin Hindman |
Re: Review Request 36605: Cleaned up 'perf' related tests to work on Ubuntu 14.04. |
Sun, 19 Jul, 18:04 |
| Benjamin Hindman |
Re: Review Request 36600: Fixes for NsTest on Ubuntu. |
Sun, 19 Jul, 18:13 |
| Benjamin Hindman |
Re: Review Request 36600: Fixes for NsTest on Ubuntu. |
Sun, 19 Jul, 18:13 |
| Benjamin Hindman |
Re: Review Request 36450: Introduced Address and URL protobufs. |
Sun, 19 Jul, 19:38 |
| Benjamin Hindman |
Re: Review Request 36425: Enabling IP Discovery script |
Sun, 19 Jul, 20:09 |
| Benjamin Hindman |
Re: Review Request 36389: Enable remote execution of arbitrary command. |
Mon, 20 Jul, 16:20 |
| Benjamin Hindman |
Re: Review Request 36574: Added a helper testing functions for Labels. |
Tue, 21 Jul, 20:10 |
| Benjamin Hindman |
Re: Review Request 36575: Added Labels to TaskStatus protobuf and expose them via state.json. |
Tue, 21 Jul, 20:15 |
| Benjamin Hindman |
Re: Review Request 36580: Added TaskStatus label decorator hook for Slave |
Tue, 21 Jul, 20:25 |
| Benjamin Hindman |
Re: Review Request 36585: Exposed docker container IP via state.json |
Tue, 21 Jul, 20:28 |
| Benjamin Hindman |
Re: Review Request 36514: [MESOS-898] Add CMake-based build system for the process library |
Wed, 22 Jul, 00:41 |
| Benjamin Hindman |
Re: Review Request 36514: [MESOS-898] Add CMake-based build system for the process library |
Wed, 22 Jul, 00:44 |
| Benjamin Hindman |
Re: Review Request 36667: Moved createLabel to protobuf_utils. |
Wed, 22 Jul, 04:15 |
| Benjamin Hindman |
Re: Review Request 36668: Removed some trailing underscores from {master, slave}_tests.cpp. |
Wed, 22 Jul, 04:16 |
| Benjamin Hindman |
Re: Review Request 36669: Fixed the order of expected value in EXPECT_EQ. |
Wed, 22 Jul, 04:16 |
| Benjamin Hindman |
Re: Review Request 36656: Removed 'SSL_ENABLE_SSL_V2' configuration flag for SSLv2. |
Wed, 22 Jul, 04:22 |
| Benjamin Hindman |
Re: Review Request 36672: Removed pthread specialization from Synchronized. |
Wed, 22 Jul, 04:23 |
| Benjamin Hindman |
Re: Review Request 36629: stout: Added support for 'synchronized_wait'. |
Wed, 22 Jul, 04:33 |
| Benjamin Hindman |
Re: Review Request 36673: Removed pthread from Once and Gate. |
Wed, 22 Jul, 04:37 |
| Benjamin Hindman |
Re: Review Request 36674: Removed pthread and used Latch in executor and scheduler drivers. |
Wed, 22 Jul, 04:41 |
| Benjamin Hindman |
Re: Review Request 36658: Updated SSL documentation. Added to home page. |
Wed, 22 Jul, 04:46 |
| Benjamin Hindman |
Re: Review Request 36279: Doxygen-ification of comments in libprocess IO headers. |
Wed, 22 Jul, 04:55 |
| Benjamin Hindman |
Re: Review Request 36618: Fixed ROOT_CGROUPS_Tasks and ROOT_CGROUPS_Read on Ubunu 14.04. |
Wed, 22 Jul, 04:57 |
| Benjamin Hindman |
Re: Review Request 36673: Removed pthread from Once and Gate. |
Wed, 22 Jul, 05:19 |
| Benjamin Hindman |
Re: Review Request 36715: Used std::thread instead of pthread for Libprocess process. |
Thu, 23 Jul, 21:03 |
| Benjamin Hindman |
Re: Review Request 36677: Introduced 'recordio' encoding facilities to stout. |
Thu, 23 Jul, 23:52 |
| Benjamin Hindman |
Re: Review Request 36763: Made the Isolator interface not dependent on IsolatorProcess. |
Fri, 24 Jul, 18:52 |
| Benjamin Hindman |
Re: Review Request 36757: Added https support. |
Fri, 24 Jul, 19:23 |
| Benjamin Hindman |
Re: Review Request 36676: Removed pthread from Zookeeper test helper. |
Fri, 24 Jul, 20:40 |
| Benjamin Hindman |
Re: Review Request 36425: Enabling IP Discovery script |
Fri, 24 Jul, 20:42 |
| Benjamin Hindman |
Re: Review Request 34128: Enable different IP/Port for external access. |
Fri, 24 Jul, 21:14 |
| Benjamin Hindman |
Re: Review Request 34129: Add 2 optional args public_ip and public_port for libprocess to advertise. |
Fri, 24 Jul, 21:23 |
| Benjamin Hindman |
Re: Review Request 36794: Handle potential 'net::hostname()' failure. |
Fri, 24 Jul, 21:26 |
| Benjamin Hindman |
Re: Review Request 36705: Libprocess: Replaced ThreadLocal use with thread_local. |
Fri, 24 Jul, 21:50 |
| Benjamin Hindman |
Re: Review Request 36677: Introduced 'recordio' encoding facilities to stout. |
Fri, 24 Jul, 22:12 |
| Benjamin Hindman |
Re: Review Request 36804: Added documentation about MesosIsolator. |
Fri, 24 Jul, 23:53 |
| Benjamin Hindman |
Re: Review Request 36754: Updated Isolator::prepare to return ContainerPrepareInfo. |
Sun, 26 Jul, 19:39 |
| Benjamin Hindman |
Re: Review Request 36755: Passed env vars returned by Isolator::prepare() to executor. |
Mon, 27 Jul, 18:27 |
| Benjamin Hindman |
Re: Review Request 36799: Renamed Executor{Limitation, RunState} to Container{Limitation, State}. |
Mon, 27 Jul, 18:28 |
| Benjamin Hindman |
Re: Review Request 36831: Allowed Isolator::prepare to return a list of CommandInfos. |
Mon, 27 Jul, 18:31 |
| Benjamin Hindman |
Re: Review Request 36823: Used std::thread instead of pthread for cgroups tests. |
Mon, 27 Jul, 19:09 |
| Benjamin Hindman |
Re: Review Request 36822: Used std::thread instead of pthread for Long Lived Executor. |
Mon, 27 Jul, 19:11 |
| Benjamin Hindman |
Re: Review Request 36824: Used std::thread instead of pthread for ns tests. |
Mon, 27 Jul, 19:12 |
| Benjamin Hindman |
Re: Review Request 36825: Removed common/thread as it is not used. |
Mon, 27 Jul, 19:12 |
| Benjamin Hindman |
Re: Review Request 36826: Removed common/factory as it is not used. |
Mon, 27 Jul, 19:12 |
| Benjamin Hindman |
Re: Review Request 36827: Removed and guarded pthread specifics for libevent-openssl. |
Mon, 27 Jul, 19:19 |
| Benjamin Hindman |
Re: Review Request 36828: Used std::thread instead of pthread for stout proc tests. |
Mon, 27 Jul, 19:21 |
| Benjamin Hindman |
Re: Review Request 36845: Stout: Introduced TLS wrapper for thread local storage. |
Mon, 27 Jul, 19:56 |
| Benjamin Hindman |
Re: Review Request 36822: Used std::thread instead of pthread for Long Lived Executor. |
Wed, 29 Jul, 22:44 |
| Benjamin Hindman |
Re: Review Request 36827: Removed and guarded pthread specifics for libevent-openssl. |
Thu, 30 Jul, 00:00 |
| Benjamin Hindman |
Re: Review Request 36824: Used std::thread instead of pthread for ns tests. |
Thu, 30 Jul, 00:00 |
| Benjamin Hindman |
Re: Review Request 36823: Used std::thread instead of pthread for cgroups tests. |
Thu, 30 Jul, 00:00 |
| Benjamin Hindman |
Re: Review Request 36828: Used std::thread instead of pthread for stout proc tests. |
Thu, 30 Jul, 22:07 |
| Benjamin Hindman |
Re: Review Request 36844: Libprocess: Used THREAD_LOCAL to replace ThreadLocal. |
Thu, 30 Jul, 22:29 |
| Benjamin Hindman |
Re: Review Request 36625: Windows: Split up platform specific functions into separate headers. |
Thu, 30 Jul, 23:24 |
| Benjamin Hindman |
Re: Review Request 36783: Windows: Header splitting continued (stout/os.hpp) |
Thu, 30 Jul, 23:24 |
| Benjamin Mahler |
Re: Review Request 34943: Added validation to flags. |
Tue, 07 Jul, 01:56 |