mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Mathiske" <be...@mesosphere.io>
Subject Re: Review Request 36946: Factored out the pattern for URL generation in a fetcher test.
Date Fri, 31 Jul 2015 07:39:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36946/#review93704
-----------------------------------------------------------



src/tests/fetcher_tests.cpp (line 343)
<https://reviews.apache.org/r/36946/#comment148115>

    This change seems to eliminate the essence of the test, namely the leading white space.


- Bernd Mathiske


On July 30, 2015, 9:37 a.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36946/
> -----------------------------------------------------------
> 
> (Updated July 30, 2015, 9:37 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Klaus Ma.
> 
> 
> Bugs: MESOS-3023
>     https://issues.apache.org/jira/browse/MESOS-3023
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Factored out the pattern for URL generation in (another)fetcher test.
> 
> 
> Diffs
> -----
> 
>   src/tests/fetcher_tests.cpp 3ded3c037bdfe7095aa15503d81a8d2ee9d420df 
> 
> Diff: https://reviews.apache.org/r/36946/diff/
> 
> 
> Testing
> -------
> 
> GTEST_FILTER='FetcherTest.OSNetUriSpaceTest' make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message