mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 32587: Stopped using RunTaskMessage.framework_id.
Date Thu, 30 Jul 2015 16:53:45 GMT


> On July 30, 2015, 9:24 a.m., Adam B wrote:
> > src/slave/slave.cpp, lines 1243-1245
> > <https://reviews.apache.org/r/32587/diff/6/?file=1025122#file1025122line1243>
> >
> >     Maybe just warn and leave the CopyFrom there?
> >     Next release, we'll remove the field entirely, and consequently this check too.
> 
> Kapil Arya wrote:
>     With the previous Master (0.23.0), the frameworkInfo.id field is always set, so I
am not sure if we need this check at all. Right now, I can't think of a case where we would
need this check. Do you have something in mind?

Fair enough. I wasn't thinking of a valid use case, just that, generally speaking, a misbehaving
sender or invalid message should not kill the slave. Logging an error is probably better here
than warning and continuing, if the master is misbehaving or really old. Dropping the issue.


- Adam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32587/#review93591
-----------------------------------------------------------


On July 30, 2015, 9:18 a.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32587/
> -----------------------------------------------------------
> 
> (Updated July 30, 2015, 9:18 a.m.)
> 
> 
> Review request for mesos, Adam B and Niklas Nielsen.
> 
> 
> Bugs: MESOS-2559
>     https://issues.apache.org/jira/browse/MESOS-2559
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> FrameworkID can be retrieved from RunTaskMessage.framework.
> 
> NOTE: This patch is only to be merged _ONLY_ after all the dependent patches have shipped,
i.e. after 0.23.0 (tracked here: https://issues.apache.org/jira/browse/MESOS-2561) has released.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp a8a195df07b5a97fdba7dfc5f312bbfa85a0d510 
>   src/slave/slave.cpp f91fa9204cd89596a3690c55c22e93429392cbfd 
>   src/tests/mesos.cpp f3b731542f9db4f966970ecb2bb96eb828350dea 
> 
> Diff: https://reviews.apache.org/r/32587/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> Also ran Nik's test-upgrade.py script (https://reviews.apache.org/r/31645) with 0.23.0
and the current master to verify compatibility checks.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message