mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 36821: Fix disable endpoints rule fails to recognize HTTP path delegates.
Date Thu, 30 Jul 2015 09:25:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36821/#review93561
-----------------------------------------------------------

Ship it!


Looks great! Unless anybody has any objections, I can remove the `using namespace` and commit
this.


3rdparty/libprocess/src/firewall.cpp (line 22)
<https://reviews.apache.org/r/36821/#comment147941>

    Shouldn't need to have a `using` for the namespace, since the code is all inside that
same namespace.


- Adam B


On July 29, 2015, 10:40 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36821/
> -----------------------------------------------------------
> 
> (Updated July 29, 2015, 10:40 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Bugs: MESOS-3143
>     https://issues.apache.org/jira/browse/MESOS-3143
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix disable endpoints rule fails to recognize HTTP path delegates.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am e9c42d7ecd44eebeadcc3d1d5011e01674b3415a 
>   3rdparty/libprocess/include/process/firewall.hpp f92a6c5bbd4af0cab43e487b0c347c30059cf162

>   3rdparty/libprocess/include/process/process.hpp 8620547148f8a69d5b661eaf08063ca72347b6a4

>   3rdparty/libprocess/src/firewall.cpp PRE-CREATION 
>   3rdparty/libprocess/src/process.cpp 6d3609d06d017d8e50d7935b335fda7ebecbd04c 
> 
> Diff: https://reviews.apache.org/r/36821/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message