mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 36908: Added QuotaInfo Protobuf.
Date Wed, 29 Jul 2015 14:11:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review93445
-----------------------------------------------------------



include/mesos/master/quota.hpp (lines 19 - 20)
<https://reviews.apache.org/r/36908/#comment147819>

    I know we are utterly inconsistent here, but my suggestion would be `__MESOS_MASTER_QUOTA_PROTO_HPP__`



include/mesos/master/quota.proto (line 26)
<https://reviews.apache.org/r/36908/#comment147818>

    Let's add a comment here. Something like:
    ```
    To stay in tune with the dynamic reservation mechanism and be able to leverage role weights,
quota is reserved per role and not per framework. This behaviour may change in the future,
and if so then most likely in coordination with dynamic reservations.
    ```



include/mesos/master/quota.proto (lines 37 - 40)
<https://reviews.apache.org/r/36908/#comment147816>

    I think we should remove it for now, since we do not plan to implement it right now, but
let's leave a TODO so that folks understand that quota != limit/



include/mesos/master/quota.proto (lines 44 - 49)
<https://reviews.apache.org/r/36908/#comment147815>

    Let's remove it for now, it's not part of the MVP.



src/Makefile.am (lines 154 - 155)
<https://reviews.apache.org/r/36908/#comment147824>

    Hard tabs here and everywhere else, please!



src/Makefile.am (line 261)
<https://reviews.apache.org/r/36908/#comment147822>

    Can we do something like `master/%.pb.cc ../include/mesos/master/%.pb.h: $(ALLOCATOR_PROTO)
$(QUOTA_PROTO)` for clarity?



src/Makefile.am (lines 482 - 484)
<https://reviews.apache.org/r/36908/#comment147823>

    Hard tabs here as well, please.


- Alexander Rukletsov


On July 29, 2015, 11:54 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36908/
> -----------------------------------------------------------
> 
> (Updated July 29, 2015, 11:54 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3164
>     https://issues.apache.org/jira/browse/MESOS-3164
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added QuotaInfo Protobuf.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/quota.hpp PRE-CREATION 
>   include/mesos/master/quota.proto PRE-CREATION 
>   src/Makefile.am 0794969b4b147e0f837006f2f2eba6c6b28eb332 
> 
> Diff: https://reviews.apache.org/r/36908/diff/
> 
> 
> Testing
> -------
> 
> make distcheck
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message