mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marco Massenzio" <>
Subject Re: Review Request 36900: Publish MasterInfo to ZK in JSON format
Date Wed, 29 Jul 2015 05:27:33 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 29, 2015, 5:27 a.m.)

Review request for mesos, Anand Mazumdar, Isabel Jimenez, and Vinod Kone.


Anand's comments

Bugs: MESOS-3135

Repository: mesos


As part of the support for non-libmesos linked client to
interact with the HTTP API, we also provide the Master information
stored in ZooKeeper in a way that is deserializable also for
clients that do not necessarily know how to decode a MasterInfo
protocol buffer.

This patch publishes the data in JSON format and has been tested,
summarily, with 2 masters running this patch alongside a 0.23 Master and
one each of 0.24 and 0.23 Agent nodes.

Please note this patch does not require specific unit testing, as the functionality
is already widely tested in existing `ZooKeeper*` tests, as well as `MasterDetector*` ones.

Diffs (updated)

  src/master/contender.cpp 2af70c7d1acf274db40cae1641cd305249a471ec 



make check
also ran: 3x Masters (2x 0.24 + 1x 0.23) / 2x Slaves (1x 0.23 + 1x 0.24)
the 0.24's were running this patch.

Also verified in ZK that the data was correct JSON:

Not sure why Reviewbot failed, but the tests all passed:
[----------] Global test environment tear-down
[==========] 684 tests from 97 test cases ran. (274274 ms total)
[  PASSED  ] 684 tests.

the error seems to be with files left in `src/credentials` and `src/master/replicated_log`:
ERROR: files left in build directory after distclean:
make[1]: *** [distcleancheck] Error 1
Am I missing something here?


Marco Massenzio

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message