mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <mazumdar.an...@gmail.com>
Subject Re: Review Request 36807: Adding a test for MasterInfo
Date Wed, 29 Jul 2015 03:12:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36807/#review93385
-----------------------------------------------------------


LGTM minus some nit comments.


src/tests/master_tests.cpp (line 2134)
<https://reviews.apache.org/r/36807/#comment147750>

    Micro nit: Can we rename the test:
    s/MasterInfo/MasterInfoAddress
    
    MasterInfo seems too general/non-intuitive to me.



src/tests/master_tests.cpp (line 2136)
<https://reviews.apache.org/r/36807/#comment147749>

    I am assuming that Vinod pushed in a fix for them. Can we remove the TODO now ?



src/tests/master_tests.cpp (line 2145)
<https://reviews.apache.org/r/36807/#comment147752>

    Can just use auto here ? It's quite self-explanatory.
    
    auto master = master_.get();



src/tests/master_tests.cpp (line 2167)
<https://reviews.apache.org/r/36807/#comment147751>

    Nit:
    
    s/Protect from flaky failures on those hosts/Protect from failures on hosts


- Anand Mazumdar


On July 29, 2015, 1:01 a.m., Marco Massenzio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36807/
> -----------------------------------------------------------
> 
> (Updated July 29, 2015, 1:01 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2736
>     https://issues.apache.org/jira/browse/MESOS-2736
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We want to test that when the master gets initialized, the
> MasterInfo that it creates (and gets ultimately serialized to
> ZooKeeper) has the correct information in its Address field.
> 
> Currently, the test hangs when run in after another
> MasterZooKeeperTest, due to some issues around the recovery.
> 
> Jira: MESOS-2736
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp 05c148ee1660b86428afe4eda718b17052743a8c 
> 
> Diff: https://reviews.apache.org/r/36807/diff/
> 
> 
> Testing
> -------
> 
> make check
> (after @vinodkone fix all tests pass)
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message