mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kapil Arya" <ka...@mesosphere.io>
Subject Re: Review Request 36831: Allowed Isolator::prepare to return a list of CommandInfos.
Date Tue, 28 Jul 2015 17:39:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36831/
-----------------------------------------------------------

(Updated July 28, 2015, 1:39 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Changes
-------

rebased


Repository: mesos


Description
-------

Previously, the Isolators had to join all the preparation commands into
a single command using `&&`. Now they can pass each command separately.


Diffs (updated)
-----

  include/mesos/slave/isolator.proto c04a4e6a5475481c72b22d0d7a0daa9ab78e069a 
  src/slave/containerizer/isolators/filesystem/shared.cpp 0047945f3dc831720d66c492a1b2c626ceb3bf00

  src/slave/containerizer/isolators/namespaces/pid.cpp 14871a9c44103294e33bd9a315cecce078e51afb

  src/slave/containerizer/isolators/network/port_mapping.cpp 77e649cc77bf29a84db48d3d914042ab5b2f695f

  src/slave/containerizer/mesos/containerizer.cpp b8045d77526053702db530792060489ee04dd8f2

  src/tests/containerizer/containerizer_tests.cpp 18c478aa5e07f839184649815b35b6e5eded92df

  src/tests/containerizer/isolator_tests.cpp 51a4db17d13dd8dbff6a5eb2ceabee269275f6f6 
  src/tests/containerizer/port_mapping_tests.cpp 778dc8cdfee1fd4098a6332b9219764527cd7b59


Diff: https://reviews.apache.org/r/36831/diff/


Testing
-------

make check.


Thanks,

Kapil Arya


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message