mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Artem Harutyunyan" <ar...@mesosphere.io>
Subject Re: Review Request 36845: Stout: Introduced THREAD_LOCAL wrapper for thread local storage.
Date Tue, 28 Jul 2015 14:49:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36845/#review93298
-----------------------------------------------------------

Ship it!



3rdparty/libprocess/3rdparty/stout/include/stout/thread_local.hpp (line 25)
<https://reviews.apache.org/r/36845/#comment147675>

    Also, by default TLS for a lot of people is Transport Layer Security. So this name will
likely cause some brain cycle waste every now and then.


- Artem Harutyunyan


On July 27, 2015, 2:05 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36845/
> -----------------------------------------------------------
> 
> (Updated July 27, 2015, 2:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park.
> 
> 
> Bugs: MESOS-3119
>     https://issues.apache.org/jira/browse/MESOS-3119
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This replaced the ThreadLocal primitive with the new c++11 standard.
> The exception is on OSX where we use `__thread` as thread_local is not
> supported.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 89e7b1854bd7f449f4f0027d76c6430d259a24de

>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 5c19e3ef8ba50ab007eda26b752441f076ca7ed0

>   3rdparty/libprocess/3rdparty/stout/include/stout/thread.hpp 552d6e97c882a36d6a889af205c422e51f544b34

>   3rdparty/libprocess/3rdparty/stout/include/stout/thread_local.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/thread_tests.cpp 319fcdf517b24f5bb9c85dad4093b09ec87e915e

> 
> Diff: https://reviews.apache.org/r/36845/diff/
> 
> 
> Testing
> -------
> 
> dependens on follow-up patch.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message