mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jan Schlicht" <...@mesosphere.io>
Subject Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.
Date Tue, 28 Jul 2015 14:06:19 GMT


> On July 28, 2015, 1:42 p.m., Joerg Schad wrote:
> > src/tests/fetcher_cache_tests.cpp, line 1450
> > <https://reviews.apache.org/r/36773/diff/3/?file=1022384#file1022384line1450>
> >
> >     Is this an expectation or assertion? IMO the test shouldn't continue if this
fails. (I see that it is the same pattern in other tests, still doens't mean it is correct
;-) )

Line 1469 is the same case and has been changed as well.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36773/#review93272
-----------------------------------------------------------


On July 28, 2015, 4:04 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36773/
> -----------------------------------------------------------
> 
> (Updated July 28, 2015, 4:04 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Joerg Schad.
> 
> 
> Bugs: MESOS-3112
>     https://issues.apache.org/jira/browse/MESOS-3112
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> A linked list is used to keep cache entries in LRU-to-MRU order. Each time an existing
cache entry is requested, it is moved to the back of the list. During cache eviction entries
are removed from the front of the list until enough cache space can be freed.
> 
> 
> Diffs
> -----
> 
>   docs/fetcher-cache-internals.md 327cbc3074bcc110e1250e2151dd5401ccaadb4b 
>   src/slave/containerizer/fetcher.hpp 17225072ba5c1c9a7209f2923bcf562fcb76201f 
>   src/slave/containerizer/fetcher.cpp e030deabd5e749100cbccabb256dbd4af8b2fe58 
>   src/tests/fetcher_cache_tests.cpp bd9c406a532a85fa95a5e9cfa6003f4893191c57 
> 
> Diff: https://reviews.apache.org/r/36773/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message