mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 36197: Documented "how to become a committer".
Date Tue, 28 Jul 2015 10:17:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36197/#review93265
-----------------------------------------------------------


I think the checklist could benefit from some organization, at least splitting it into the
half that the candidate fills out and the half that the nominator fills out. Bonus points
for a logical ordering/grouping within those.


docs/committer-candidate-checklist.md (line 7)
<https://reviews.apache.org/r/36197/#comment147639>

    s/Project//
    s/as for instance/e.g./



docs/committer-candidate-checklist.md (line 9)
<https://reviews.apache.org/r/36197/#comment147638>

    I'm not convinced these `<input type="text"/>` will actually show up on the website,
or even github.
    
    Let's leave `Nomination date` out of the checklist, since that comes implicitly when the
nominator makes the actual nomination, and is impossible to guess before then.



docs/committer-candidate-checklist.md (line 15)
<https://reviews.apache.org/r/36197/#comment147640>

    Please add ReviewBoard username, since that's how we actually generate the Author field
in the git commits.
    As far as I know, a github profile is unnecessary and irrelevant.



docs/committer-candidate-checklist.md (lines 19 - 20)
<https://reviews.apache.org/r/36197/#comment147641>

    Please add links to explanations of the Apache Way, otherwise new contributors will be
clueless.



docs/committer-candidate-checklist.md (lines 22 - 26)
<https://reviews.apache.org/r/36197/#comment147642>

    These are rather vague. Are they meant to be filled in by the Nominator or the candidate?
Either way, it'd be nice to give some hints/examples of how these would be demonstrated.



docs/committer-candidate-checklist.md (lines 35 - 36)
<https://reviews.apache.org/r/36197/#comment147643>

    Another one that the candidate can't fill out themselves.
    Maybe it would be best to break this down into the "candidate checklist" part that the
candidate fills out (all my ids/stats/queries, etc.) and the "nomination form" that the nominator
fills out.



docs/committer-candidate-checklist.md (lines 69 - 71)
<https://reviews.apache.org/r/36197/#comment147637>

    Let's generalize this so the candidate can choose how to provide evidence:
    ```
    * Evidence of testing as a priority:
    A simple metric could be <#tests written> / <#testable tickets>. Or you could
detail a particularly complex set of unit tests you had to write. Or explain how you have
improved the project's testing infrastructure or best practices.
    ```



docs/committer-candidate-checklist.md (line 77)
<https://reviews.apache.org/r/36197/#comment147645>

    Doesn't this go along with the community participation section?



docs/committers.md (line 7)
<https://reviews.apache.org/r/36197/#comment147634>

    s/developer/contributor/
    My recommended wording:
    "An Apache Mesos committer is a contributor with write access to the Mesos repositories
and related Apache infrastructure. In the Mesos project, each committer is also a voting member
of the PMC."
    Since this is more about the responsibilities/privileges of being a committer, the ICLA
seems like an irrelevant administrative detail.



docs/committers.md (line 11)
<https://reviews.apache.org/r/36197/#comment147635>

    s/elected/voted in/ since an election implies a choice of candidates.


- Adam B


On July 28, 2015, 1:11 a.m., Bernd Mathiske wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36197/
> -----------------------------------------------------------
> 
> (Updated July 28, 2015, 1:11 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-1815
>     https://issues.apache.org/jira/browse/MESOS-1815
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added new document "committer-candidate-checklist.md" and wrote
> a paragraph about the path to committership in "committers.md".
> 
> 
> Diffs
> -----
> 
>   docs/committer-candidate-checklist.md PRE-CREATION 
>   docs/committers.md ca8a6995c5272f3534ab63f95332565dfcaaf5b9 
> 
> Diff: https://reviews.apache.org/r/36197/diff/
> 
> 
> Testing
> -------
> 
> The rendered files can be viewed here:
> 
> https://gist.github.com/bernd-mesos/00de63ae13efec4331be
> 
> 
> Thanks,
> 
> Bernd Mathiske
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message