mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "haosdent huang" <haosd...@gmail.com>
Subject Re: Review Request 36811: Don't check protobuf jar when --disable-java flag.
Date Tue, 28 Jul 2015 02:12:50 GMT


> On July 27, 2015, 7:29 p.m., Marco Massenzio wrote:
> > configure.ac, lines 1093-1096
> > <https://reviews.apache.org/r/36811/diff/1/?file=1021876#file1021876line1093>
> >
> >     did you really mean to move and then comment out these lines? shouldn't they
be uncommented here?

Sorry for upload the wrong branch, let me update again.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36811/#review93169
-----------------------------------------------------------


On July 25, 2015, 8:23 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36811/
> -----------------------------------------------------------
> 
> (Updated July 25, 2015, 8:23 a.m.)
> 
> 
> Review request for mesos, Adam B and Niklas Nielsen.
> 
> 
> Bugs: MESOS-2480
>     https://issues.apache.org/jira/browse/MESOS-2480
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Don't check protobuf jar when --disable-java flag.
> 
> 
> Diffs
> -----
> 
>   configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500 
> 
> Diff: https://reviews.apache.org/r/36811/diff/
> 
> 
> Testing
> -------
> 
> ../configure --with-protobuf=/usr/local --disable-java
> make -j4
> make check -j4 GTEST_FILTER=-"*"
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message